- Unit Test provided
- Does this require a behat test?
- Deprecated code removed
- Is all markup and styles accessible?
- Syntax & Formatting is correct (Code Climate should take care of this)
- Is the approach to the problem appropriate?
- Can anything be simplified?
- Is the code too specific to _ and needs generalization:
- Site?
- Product?
- Stanford?
- Do forms need to sanitized
- Any obvious security flaws or potential holes
- Are the naming conventions appropriate?
- Are there enough comments inline with the code?
- Is there documentation needed?
- Is there anything included that should not be?
- Are all dependencies declared?
- Does the PR follow development standards?
- Are all content (labels and other strings) translated?
- Is there anything in this code that would be hidden or hard to discover through the UI?
- Are there any code smells? https://blog.codinghorror.com/code-smells/
Last active
November 29, 2022 11:05
-
-
Save sherakama/0ba17601381e3adbe0cad566ad4d80a5 to your computer and use it in GitHub Desktop.
Pull Request Checklist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thank you so much!