Skip to content

Instantly share code, notes, and snippets.

@shigeki
Created November 13, 2015 04:36
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save shigeki/f523f894f6d739f59364 to your computer and use it in GitHub Desktop.
Save shigeki/f523f894f6d739f59364 to your computer and use it in GitHub Desktop.
change test-tls-honorcipherorder.js to work on only TLS1.2 cipher
'use strict';
var common = require('../common');
var assert = require('assert');
if (!common.hasCrypto) {
console.log('1..0 # Skipped: missing crypto');
return;
}
var tls = require('tls');
var fs = require('fs');
var nconns = 0;
// We explicitly set TLS version to 1.2 so as to be safe when the
// default method is updated in the future
var SSL_Method = 'TLSv1_2_method';
var localhost = '127.0.0.1';
process.on('exit', function() {
assert.equal(nconns, 6);
});
function test(honorCipherOrder, clientCipher, expectedCipher, cb) {
var soptions = {
secureProtocol: SSL_Method,
key: fs.readFileSync(common.fixturesDir + '/keys/agent2-key.pem'),
cert: fs.readFileSync(common.fixturesDir + '/keys/agent2-cert.pem'),
ciphers: 'AES256-SHA256:AES128-GCM-SHA256:AES128-SHA256:ECDHE-RSA-AES128-GCM-SHA256',
honorCipherOrder: !!honorCipherOrder
};
var server = tls.createServer(soptions, function(cleartextStream) {
nconns++;
// End socket to send CLOSE_NOTIFY and TCP FIN packet, otherwise
// it may hang for ~30 seconds in FIN_WAIT_1 state (at least on OSX).
cleartextStream.end();
});
server.listen(common.PORT, localhost, function() {
var coptions = {
rejectUnauthorized: false,
secureProtocol: SSL_Method
};
if (clientCipher) {
coptions.ciphers = clientCipher;
}
var client = tls.connect(common.PORT, localhost, coptions, function() {
var cipher = client.getCipher();
client.end();
server.close();
assert.equal(cipher.name, expectedCipher);
if (cb) cb();
});
});
}
test1();
function test1() {
// Client has the preference of cipher suites by default
test(false, 'AES128-GCM-SHA256:AES256-SHA256:AES128-SHA256', 'AES128-GCM-SHA256', test2);
}
function test2() {
// Server has the preference of cipher suites where AES256-SHA256 is in
// the first.
test(true, 'AES128-GCM-SHA256:AES256-SHA256:AES128-SHA256', 'AES256-SHA256', test3);
}
function test3() {
// Server has the preference of cipher suites. AES128-GCM-SHA256 is given
// higher priority over AES128-SHA256 among client cipher suites.
test(true, 'AES128-SHA256:AES128-GCM-SHA256', 'AES128-GCM-SHA256', test4);
}
function test4() {
// As client has only one cipher, server has no choice in regardless
// of honorCipherOrder.
test(true, 'AES128-SHA256', 'AES128-SHA256', test5);
}
function test5() {
// Client did not explicitly set ciphers and client offers tls.DEFAULT_CIPHERS.
// All ciphers of the server is included in the default list so the negotiated
// cipher is selected accroding to the server's top preference of AES256-SHA256.
test(true, null, 'AES256-SHA256', test6);
}
function test6() {
// Ensure that `tls.DEFAULT_CIPHERS` is used
tls.DEFAULT_CIPHERS = 'ECDHE-RSA-AES128-GCM-SHA256';
test(true, null, 'ECDHE-RSA-AES128-GCM-SHA256');
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment