shqking

Tracing JIT issue on laravel benchmark.

1. Both JIT/arm64 and JIT/x86 are affected.
2. only CALL+noGRV is affected. JIT has three configurations, HYBRID, CALL with global register variabels feature(CALL+GRV for short) and CALL+noGRV. In my local test, only CALL+noGRV has this issue, i.e. --disable-gcc-global-regs should be passed.

Reproduce in laravel:

php vendor/bin/phpunit --group default

shqking

```
# php vendor/bin/phpunit ./tests/Integration/Notifications/SendingNotificationsWithLocaleTest.php
PHPUnit 9.5.10 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.2.0-dev
Configuration: /opt/php-oss/framework/phpunit.xml.dist

......AddressSanitizer:DEADLYSIGNAL
=================================================================
==410160==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000348 (pc 0x7f28ee00886f bp 0x7ffe6a700290 sp 0x7ffe6a700210 T0)

shqking

Try out PHP JIT on AArch64 platform

Pre-reading

I assume you probably tried out the JIT compiler with PHP 8.0 particularly under x86/x86_64 platforms. If not, you can have a basic understanding of PHP JIT with these two blogs.

• PHP 8: How to setup the JIT
• Try out JIT compiler with PHP 8.0

shqking

diff --git a/ext/standard/array.c b/ext/standard/array.c
index 6345dd4ebb..98997fb493 100644
--- a/ext/standard/array.c
+++ b/ext/standard/array.c
@@ -2782,6 +2782,7 @@ double_str:

                        ZEND_HASH_FILL_PACKED(Z_ARRVAL_P(return_value)) {
                                for (i = 0, element = low; i < size && element <= high; ++i, element = low + (i * step)) {
+                                       printf("element %d-th: %.16f\n", i, element);
                                        ZEND_HASH_FILL_SET_DOUBLE(element);

shqking

#include <stdio.h>
#include <stdlib.h>
#include <sys/mman.h>
#include <unistd.h>
#include <string.h>
#include <limits.h>
#include <fcntl.h>
#include <sys/stat.h>

#define READ_ADDR(addr, offset) printf("==" #addr ": offset " #offset ": %p, value: %d\n", addr + offset, *(addr + offset));

shqking

opcache.jit=0 (failed in both x86 and arm64）

# ERROR 1: Laravel
Fatal error: During inheritance of JsonSerializable: Uncaught Declaration of Illuminate\Support\Fluent::jsonSerialize() should be compatible with JsonSerializable::jsonSerialize(): mixed

# ERROR 2: Amphp
Fatal error: PHPUnit\Framework\Error\Deprecated: Implicit conversion from float-string "15.24" to int loses precision in /opt/php-oss/amp/test/PromiseTest.php:329

shqking

libdyld.dylib`tlv_get_addr:
->  0x19eb86940 <+0>:   ldr    x16, [x0, #0x8]
    0x19eb86944 <+4>:   mrs    x17, TPIDRRO_EL0
    0x19eb86948 <+8>:   and    x17, x17, #0xfffffffffffffff8
    0x19eb8694c <+12>:  ldr    x17, [x17, x16, lsl #3]
    0x19eb86950 <+16>:  cbz    x17, 0x19eb86960          ; <+32>
    0x19eb86954 <+20>:  ldr    x16, [x0, #0x10]
    0x19eb86958 <+24>:  add    x0, x17, x16
    0x19eb8695c <+28>:  ret
    0x19eb86960 <+32>:  stp    x29, x30, [sp, #-0x10]!

shqking

####Test case:

#include <stdio.h>
#include <pthread.h>
#include <unistd.h>

__thread int x = 0;

int main()
{