Created
June 30, 2013 16:05
-
-
Save sloria/5895749 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Bad | |
# Can't change type of collection | |
# e.g. can't change employees from a list to a set | |
class Department: | |
def __init__(self, *employees): | |
self.employees = employees | |
for employee in department.employees: | |
... | |
# Better | |
class Department: | |
def __init__(self, *employees): | |
self._employees = employees | |
def __iter__(self): | |
return iter(self._employees) | |
for employee in department: # More readable, more composable | |
... | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment