Skip to content

Instantly share code, notes, and snippets.

@smccarney
Created March 19, 2019 14:25
Show Gist options
  • Save smccarney/79186e8510ba5479e846f2592d44d059 to your computer and use it in GitHub Desktop.
Save smccarney/79186e8510ba5479e846f2592d44d059 to your computer and use it in GitHub Desktop.
Test Plan: Redfish: Enhance and fix power/thermal sensors
Test Plan
---------
x Run Redfish-Service-Validator
x Verify changes do not introduce any new errors
x power.hpp
x Test where built with BMCWEB_ENABLE_REDFISH_ONE_CHASSIS=1
x Verify power sensors are returned
x thermal.hpp
x Test where built with BMCWEB_ENABLE_REDFISH_ONE_CHASSIS=1
x Verify thermal sensors are returned
x Verify sensors of type fan_tach are returned
x sensors.hpp
x SensorsAsyncResp()
x Power
x Verify @odata.id value is /redfish/v1/Chassis/chassis/Power
x Thermal
x Verify @odata.id value is /redfish/v1/Chassis/chassis/Thermal
x isRequestedSensorType()
x Test where sensor type is requested
x First type in type list
x Last type in type list
x Test where sensor type is not requested
x getConnections()
x Connection provides only Thermal sensors
x Verify added to set when Thermal sensors requested
x Verify not added to set when Power sensors requested
x Connection provides only Power sensors
x Verify added to set when Power sensors requested
x Verify not added to set when Thermal sensors requested
x Connection provides both Power and Thermal sensors
x Verify added to set when Power sensors requested
x Verify added to set when Thermal sensors requested
x getAllSensors()
x Test where DBus error occurs
x Test where object path does not contain "/"
x Verify obtains sensor name from object path
x Verify all sensor names added to set
x Verify all debug and error messages
x getObjectManagerPaths()
x Test where DBus error occurs
x Verify adds correct mapping from all connections to their corresponding
object path
x Verify all debug and error messages
x objectInterfacesToJson()
x Verify the following properties are returned for sensor types other than
current or power:
x UpperThresholdNonCritical
x LowerThresholdNonCritical
x UpperThresholdCritical
x LowerThresholdCritical
x Verify the following properties are not returned for sensor types
current and power:
x UpperThresholdNonCritical
x LowerThresholdNonCritical
x UpperThresholdCritical
x LowerThresholdCritical
x Verify the following properties are returned for temperature sensors
x MinReadingRangeTemp
x MaxReadingRangeTemp
x Verify the following properties are returned for sensors that are not of
type temperature, current, and power
x MinReadingRange
x MaxReadingRange
x Verify the following properties are not returned for sensor types
current and power:
x MinReadingRange
x MaxReadingRange
x MinReadingRangeTemp
x MaxReadingRangeTemp
x getSensorData()
x Test where GetManagedObjects method fails with DBus error
x Test where sensor returned from GetManagedObjects is one of the requested
types. Verify included in output.
x Test where sensor returned from GetManagedObjects is not one of the
requested types. Verify not included in output.
x Test where object path doesn't have enough nodes
x Test where returned sensor is not in set of desired sensors
x Test where sensor type is temperature
x Test where sensor type is fan_tach
x Test where sensor type is voltage
n Test where sensor type is current
x Test where sensor type is power
x Test where sensor type is unexpected
x Verify JSON contains expected values
x Temperature
x Fan
x Voltage
x PowerSupply
x Verify correct object path used for calling GetManagedObjects for each
connection.
x Verify object path defaults to "/" if no mapping found
x Verify all debug and error messages
x getChassisData()
x Test where built with BMCWEB_ENABLE_REDFISH_ONE_CHASSIS=1
x Verify gets all sensors and doesn't use EntityManager
x Test where built with BMCWEB_ENABLE_REDFISH_ONE_CHASSIS=0
x Verify tries to get only sensors in current chassis using EntityManager
x Verify all debug and error messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment