Last active
June 17, 2017 21:23
-
-
Save smerritt/7605771 to your computer and use it in GitHub Desktop.
OpenStack Swift code review checklist
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Are there tests? Do the new tests fail if the code is reverted? | |
| * Does it work? There's no such thing as obviously correct, as I've had to learn again and again. | |
| * Check the coverage report; is any new code uncovered? (This might be okay, but take a look.) | |
| * How's the logging? | |
| * Read all the tests; any leftover debugging cruft? Print statements seem particularly common. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment