Last active
December 21, 2018 02:42
-
-
Save sorcerykid/68056c844f927618bae1fb315b5bf9f7 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have been contributing code to Minetest for months, not just sitting on code. |
Thanks for your contribution. The mod works, but it's somewhat slow. You could use the Lua VoxelManipulator to speed up the node replacement a bit. If that's a bit complicated, then consider replacing
set_node
withswap_node
, which also improves the performance a bit by skipping the Lua callbacks.
Apparently Krock even admits that "contributions" can include mods.
https://forum.minetest.net/viewtopic.php?p=326381#p326381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rubenwardy: well, socerykid does a nice job. perhaps try to catch as a core dev?
17:18 rubenwardy yeah, no
17:18 she's never helped review
17:18 or actually contributed
17:19 just thrown posted some random patches (which could cause data loss due to reduce save interval) on the forums
17:19 I'd welcome that to start now however :)
17:19 Sokomine perhaps it just takes a bit more talking with each other? most of socerykids work seems to be more of intrest for the engine and server owners than for individual players
17:19 that'd be nice, yes :-)
17:20 it's not as if core devs grow on trees .-)
17:20 plants a sapling...and...er...hopes
17:20 rubenwardy unfortunately not :(
17:20 we do need more core devs, and for that you need more contributors
17:21 the path usually goes:
17:21 Krock joined #minetest-hub
17:21 rubenwardy casual contributor -> contributor who also looks at other peoples PRs -> contributor who actively finds bugs and issues with other prs -> core devs
Apparently i posted multiple patches that can result in data loss, ignoring the fact that sfan5 contributed a PR that not only threatens data loss, but can actually take down a server. apparently these core devs don't understand the concept of a hotfix. my patch wasn't intended to be a "contribution", it was simply an interim fix for server operators to regain control of their server.