Last active
January 5, 2024 17:50
-
-
Save spion/8c9d8556697ed61108177164e90fb50d to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function translateError(msg) { | |
var newErr = new Error(msg); // placed here to get correct stack | |
return e => { | |
newErr.originalError = e; | |
throw newErr; | |
} | |
} | |
async function asyncTask() { | |
const user = await UserModel.findById(1).catch(translateError('No user found')) | |
if(!user) throw new Error('No user found'); | |
const savedTask = await TaskModel({userId: user.id, name: 'Demo Task'}) | |
.catch(translateError('Error occurred while saving task')) | |
if(user.notificationsEnabled) { | |
await NotificationService.sendNotification(user.id, 'Task Created') | |
.catch(translateError('Error while sending notification')) | |
} | |
if(savedTask.assignedUser.id !== user.id) { | |
await NotificationService.sendNotification(savedTask.assignedUser.id, 'Task was created for you') | |
.catch(translateError('Error while sending notification')) | |
} | |
return savedTask | |
} |
Ok now I see it. No, that code has an error - returning a promise from a promise constructor doesn't do anything, that return value is ignored.
In the first examples it does something not because there is a return, but because an error is thrown and the catch statement rejects the outer promise.
In the non-working case an error is not thrown, so the catch statement doesn't run, so the outer promise never gets resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think @phra has a point. @spion