Skip to content

Instantly share code, notes, and snippets.

@springmeyer
Created January 6, 2012 23:15
Show Gist options
  • Save springmeyer/1572893 to your computer and use it in GitHub Desktop.
Save springmeyer/1572893 to your computer and use it in GitHub Desktop.
diff --git a/tools/gyp/pylib/gyp/generator/make.py b/tools/gyp/pylib/gyp/generator/make.py
index 1007672..da527bd 100644
--- a/tools/gyp/pylib/gyp/generator/make.py
+++ b/tools/gyp/pylib/gyp/generator/make.py
@@ -883,8 +883,8 @@ class XcodeSettings(object):
else:
raise NotImplementedError('Unknown debug format %s' % dbg_format)
- if self._Test('GCC_SYMBOLS_PRIVATE_EXTERN', 'YES', default='NO'):
- cflags.append('-fvisibility=hidden')
+ #if self._Test('GCC_SYMBOLS_PRIVATE_EXTERN', 'YES', default='NO'):
+ #cflags.append('-fvisibility=hidden')
if self._Test('GCC_TREAT_WARNINGS_AS_ERRORS', 'YES', default='NO'):
cflags.append('-Werror')
@@ -909,7 +909,7 @@ class XcodeSettings(object):
self._WarnUnimplemented('PRODUCT_TYPE')
# TODO: Do not hardcode arch. Supporting fat binaries will be annoying.
- cflags.append('-arch i386')
+ #cflags.append('-arch i386')
cflags += self._Settings().get('OTHER_CFLAGS', [])
cflags += self._Settings().get('WARNING_CFLAGS', [])
@@ -938,8 +938,8 @@ class XcodeSettings(object):
cflags_cc.append('-fno-rtti')
if self._Test('GCC_ENABLE_CPP_EXCEPTIONS', 'NO', default='YES'):
cflags_cc.append('-fno-exceptions')
- if self._Test('GCC_INLINES_ARE_PRIVATE_EXTERN', 'YES', default='NO'):
- cflags_cc.append('-fvisibility-inlines-hidden')
+ #if self._Test('GCC_INLINES_ARE_PRIVATE_EXTERN', 'YES', default='NO'):
+ #cflags_cc.append('-fvisibility-inlines-hidden')
if self._Test('GCC_THREADSAFE_STATICS', 'NO', default='YES'):
cflags_cc.append('-fno-threadsafe-statics')
self.configname = None
@@ -1003,7 +1003,7 @@ class XcodeSettings(object):
'-Wl,' + target.Absolutify(self._Settings()['ORDER_FILE']))
# TODO: Do not hardcode arch. Supporting fat binaries will be annoying.
- ldflags.append('-arch i386')
+ #ldflags.append('-arch i386')
# Xcode adds the product directory by default.
ldflags.append('-L' + generator_default_variables['PRODUCT_DIR'])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment