Skip to content

Instantly share code, notes, and snippets.

@srivastavarobin
Last active August 4, 2023 10:32
Show Gist options
  • Star 25 You must be signed in to star a gist
  • Fork 13 You must be signed in to fork a gist
  • Save srivastavarobin/8954241 to your computer and use it in GitHub Desktop.
Save srivastavarobin/8954241 to your computer and use it in GitHub Desktop.
Code Review Checklist for Android (Java Only)

My Android Java Code Review Checklist

  1. Is the functionality correct?
  2. Are the classes named suitably?
  3. Are the functions named suitably?
  4. How's the datastructure being used? Is it the correct DS or it needs improvement?
  5. Can the classes be further borken into small classes?
  6. Do we need an interface?
  7. If it contain functions that can be reused later then are there Utils created for them?
  8. Can it use already available Util functions?
  9. Does the large set of input for a function deserve a new bean to be created?
  10. Can we decrease the coupling?
  11. Are all the input arguments being validated?
  12. How will the functionalities affect the performance of the app - time and memory?
  13. Is it absolutely necessary to run it on UI therad or would a background thread suffice?
  14. Are all the fail points handled?
  15. Does it degrade gracefully in case of unknown failures?
  16. Are the app-doing level standards being followed?
  17. Is the correct form of storage being used and is memory available for storage? * Shared Preference * DB * SD Card * Internal Storage
  18. Are the operations thread safe?
  19. What pieces of the component can be executed in parallel?
  20. Are the layouts suitable for all the screen dimensions?
  21. What classes would become obsolete after this implementation?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment