Skip to content

Instantly share code, notes, and snippets.

@stephendonner
Last active February 12, 2021 23:23
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save stephendonner/8305c533158101cbdb61d86d9e7adee1 to your computer and use it in GitHub Desktop.
Save stephendonner/8305c533158101cbdb61d86d9e7adee1 to your computer and use it in GitHub Desktop.

brave/brave-browser#13379

Verified FIXED using

Brave 1.21.51 Chromium: 88.0.4324.152 (Official Build) beta (x86_64)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS macOS Version 11.2.1 (Build 20D74)

Rewards Panel

  1. Open browser with a clean profile.
  2. Open the Rewards panel.
  3. Click "Take a quick tour".
  4. Verify that tour does not include the setup form. (screenshot)
  5. Navigate through the tour and click "Done".
  6. Click "Start using Rewards".
  7. Verify that the tour includes the setup form.
  8. Change the selected values for "Ads per hour" and "AC amount".
  9. Close the Rewards panel.
  10. Navigate to brave://rewards.
  11. Verify that the "Ads per hour" and "AC amount" selected in the tour are reflected on the Auto-Contribute Settings page. (screenshots)

Verified:

  • step 4, initial tour does not include the setup form
  • step 7, tour includes the setup form on page 7
  • step 11, defaults: 2 ads per hour under "Ads", and up to 20.000 BAT monthly contribution, in Auto-Contribute Settings
  • step 11, custom: changed to 5 ads per hour, 10.000 BAT monthly contribution

Rewards Page

  1. Open browser with a clean profile.
  2. Navigate to brave://rewards.
  3. Click "Take a quick tour".
  4. Verify that tour does not include the setup form.
  5. Click "Start using Rewards".
  6. Verify that tour contains the setup form.
  7. Change the selected values for "Ads per hour" and "AC amount".
  8. Exit the tour.
  9. Verify that the "Ads per hour" and "AC amount" selected in the tour are reflected on the settings page.

Verified:

  • step 4, quick tour does not include the setup form
  • step 6, quick tour does include the setup form on page 7
  • step 9, defaults: 2 ads per hour under "Ads", and up to 20.000 BAT monthly contribution, in Auto-Contribute Settings
  • step 9, custom: changed to 1 ad per hour, 10.000 BAT monthly contribution

Tip Dialog

  1. Open browser with a clean profile pointed to staging.
  2. Navigate to a verified publisher URL (e.g. https://laurenwags.github.io).
  3. Open the Rewards panel.
  4. Cancel the onboarding dialog.
  5. Click "Send a tip".
  6. On the tip dialog, click "Take a quick tour".
  7. Verify that tour does not include the setup form.
  8. Click "Start using Rewards".
  9. Verify that tour contains the setup form.
  10. Change the selected values for "Ads per hour" and "AC amount".
  11. Exit the tour and close the tip dialog.
  12. Navigate to brave://rewards.
  13. Verify that the "Ads per hour" and "AC amount" selected in the tour are reflected on the settings page. (screenshots)

Verified:

  • step 4, pressed "X" to close; (pressing Escape key dismisses)
  • step 7, tour does not include setup form
  • step 9, tour now does include setup form in page 7
  • step 13, defaults: 2 ads per hour under Ads, and up to 20.000 BAT monthly contribution, in Auto-Contribute Settings
  • step 13, custom: 3 ads per hour, and up to 15.000 BAT monthly contribution, in Auto-Contribute Settings
@stephendonner
Copy link
Author

stephendonner commented Feb 12, 2021

cases to add/consider:

  • wide vs. regular tour-panel sizes
  • light/dark theme variations
  • localizations (with long strings as in Greek/German, others; RTL?)
  • edge-ish cases (other nav paths, sequences)
  • negative testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment