Openrisc 4.11 2016 Jan 14 - checkpatch

https://github.com/stffrdhrn/linux/commits/openrisc-4.11
a98de29663be5d1917bf12d220c39e25a59c6da5


-------------------------------------------------------
or1k-4.11/0006-openrisc-add-l.lwa-l.swa-emulation.patch
-------------------------------------------------------

WARNING: externs should be avoided in .c files
#130: FILE: arch/openrisc/kernel/process.c:229:
+extern int lwa_flag;

ERROR: do not use assignment in if condition
#261: FILE: arch/openrisc/kernel/traps.c:440:
+               if ((entry = search_exception_tables(orig_pc))) {


-----------------------------------------------
or1k-4.11/0007-openrisc-add-atomic-bitops.patch
-----------------------------------------------


WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#124: FILE: arch/openrisc/include/asm/bitops/atomic.h:83:
+static inline int test_and_clear_bit(int nr, volatile unsigned long *addr)


------------------------------------------------------------------
or1k-4.11/0008-openrisc-add-cmpxchg-and-xchg-implementations.patch
------------------------------------------------------------------

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#65: FILE: arch/openrisc/include/asm/cmpxchg.h:23:
+__cmpxchg(volatile void *ptr, unsigned long old, unsigned long new, int size)

ERROR: code indent should use tabs where possible
#88: FILE: arch/openrisc/include/asm/cmpxchg.h:46:


-------------------------------------------------------------
or1k-4.11/0009-openrisc-add-optimized-atomic-operations.patch
-------------------------------------------------------------
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36:
new file mode 100644

WARNING: unnecessary whitespace before a quoted newline
#59: FILE: arch/openrisc/include/asm/atomic.h:19:
+               "1:     l.lwa   %0,0(%1)        \n"

---------------------------------------------------------
or1k-4.11/0010-openrisc-add-spinlock-implementation.patch
---------------------------------------------------------

ERROR: code indent should use tabs where possible
#64: FILE: arch/openrisc/include/asm/spinlock.h:50:
+        smp_mb();$

WARNING: Missing a blank line after declarations
#116: FILE: arch/openrisc/include/asm/spinlock.h:102:
+       struct __raw_tickets tickets = ACCESS_ONCE(lock->tickets);
+       return (tickets.next - tickets.owner) > 1;

WARNING: memory barrier without comment
#217: FILE: arch/openrisc/include/asm/spinlock.h:203:
+       smp_mb();

WARNING: unnecessary whitespace before a quoted newline
#242: FILE: arch/openrisc/include/asm/spinlock.h:228:
+               "        l.nop                          \n"

WARNING: memory barrier without comment
#250: FILE: arch/openrisc/include/asm/spinlock.h:236:
+               smp_mb();


WARNING: Prefer READ_ONCE(<FOO>) over ACCESS_ONCE(<FOO>)
#258: FILE: arch/openrisc/include/asm/spinlock.h:244:
+#define arch_read_can_lock(x)          (ACCESS_ONCE((x)->lock) < 0x80000000)

WARNING: do not add new typedefs
#283: FILE: arch/openrisc/include/asm/spinlock_types.h:10:
+typedef struct {


---------------------------------------------------------------
or1k-4.11/0011-openrisc-add-futex_atomic_-implementations.patch
---------------------------------------------------------------

WARNING: ENOSYS means 'invalid syscall nr' and nothing else
#107: FILE: arch/openrisc/include/asm/futex.h:66:
+               ret = -ENOSYS; 

WARNING: ENOSYS means 'invalid syscall nr' and nothing else
#133: FILE: arch/openrisc/include/asm/futex.h:92:
+                       ret = -ENOSYS;

WARNING: unnecessary whitespace before a quoted newline
#150: FILE: arch/openrisc/include/asm/futex.h:109:
+               "1:     l.lwa   %1, %2          \n"     \


----------------------------------------------------------------
or1k-4.11/0014-openrisc-Initial-support-for-the-idle-state.patch
----------------------------------------------------------------
WARNING: Missing a blank line after declarations
#35: FILE: arch/openrisc/kernel/process.c:85:
+       unsigned long upr;
+       local_irq_enable();

total: 0 errors, 1 warnings, 19 lines checked