Skip to content

Instantly share code, notes, and snippets.

@stowball
Last active October 4, 2017 20:17
Show Gist options
  • Save stowball/e6b5151fb42e66133a96f5945b28d057 to your computer and use it in GitHub Desktop.
Save stowball/e6b5151fb42e66133a96f5945b28d057 to your computer and use it in GitHub Desktop.
Front-End PR Checklist

Answer Y/N/NA to all questions as appropriate.
Delete sections that don't apply.

Linting
Have you fixed all:

  • CSS errors?
  • JS errors?

Browsers
Have you tested this in:

  • Chrome?
  • Firefox?
  • Safari?
  • Edge?
  • IE 11?
  • Safari on iOS?
  • Chrome on Android?

Responsive
Have you tested this at the following breakpoints:

  • 320px?
  • 360px?
  • 375px?
  • 600px?
  • 768px?
  • 960px?
  • 1024px?
  • 1280px?
  • 1400px?
  • 1600px?

Markup
Have you:

  • Tested every variant?
  • Validated the markup?
  • Used a sensible heading hierarchy without skipping levels?
  • Provided visually-hidden, meaningful text for non-sighted users?

Accessibility
Have you:

  • Ensured all interactive elements have appropriate :hover & :focus states?
  • Added appropriate aria, alt, for and id attributes?
  • Ensured all interactive elements are reachable & usable with the keyboard?
  • Tested in a screen-reader (VoiceOver, ChromeVox, NVDA or Lynx)?

SVG
Have you:

  • Visually centered it on a 100x100 canvas?
  • Simplified and consolidated paths?

Optimisation
Have you minified:

  • public/images?
  • public/svg?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment