Notes from a short drupal sprint to review a submitted patch and submit a new patch in the issue queues

drupal_contrib_sprint.md

1. To get started quick, the first thing I did was list all the contrib modules of one of projects I am currently working on. From in there, I decided to visit the issues page of simplenews module.
2. Filtered the issues to find an easy patch to review like this and then picked this - https://drupal.org/node/1814244
3. Found useful links
   • simple and just what I was looking for - https://drupal.org/patch/review
   • learned here why my git apply always failed - https://drupal.org/patch/apply
   • ideally I should have created a dev virgin drupal setup to test the patch like this - https://drupal.org/dev-env - but I used my existing project setup. (BUT not before checking that I was using the same version of the module).
   • good lesson, but I did not really use this - http://drupalladder.org/lesson/32c03c97-5fd5-c5d4-497c-9c54a309d557
   • xhm's notes on how to review - http://xjm.drupalgardens.com/blog/core-mentoring-and-xjms-guide-patch-reviews
4. created a new branch in my project (which was already a git repo) git checkout -b sprint
5. downloaded the patch inside the simplenews module folder wget https://drupal.org/files/subscriber_count-1814244-2.patch
6. applied the patch patch -p1 < subscriber_count-1814244-2.patch
7. Noticed in the diff that the new code added was a little off on whitespaces git diff
8. checked that the issue at hand was actually resolved by visiting the page http://mysite.com/admin/config/services/simplenews
9. updated the issue with my findings and changed the status to NW (needs work) so that I could submit a patch with whitespace fixes - https://drupal.org/node/1814244#comment-7753363