Skip to content

Instantly share code, notes, and snippets.

View suryasaini96's full-sized avatar
🎯
Focusing

Surya Saini suryasaini96

🎯
Focusing
  • Delhi
View GitHub Profile
@suryasaini96
suryasaini96 / qmoney_module4_issues.md
Last active July 26, 2021 06:18
QMoney Module 4 Issues Identified

QMoney Module 4 Issues

Alright folks, finally I got my code to work. Here are the issues in QMoney Module 4 that I've identified. I suggest @Team Crio @Crio Assist to please re-visit this module to fix them. Will save a lot of time in future for other people 🙂 :-

  1. The cloned code stub has missing implementations
  • In PortfolioManagerApplication.java there's a method called readFileAsString() used whose implementation is missing (although this function serves no use later). Similarly, there's a getStockQuote() method in PortfolioManagerImpl.java which is also missing. If these are the TODOs then what we're supposed to implement in them is missing (had to copy them from intro video). The TODO comments within the files are also not clear. If possible they should be added in milestones only. These two methods were newly introduced in this module only. There's also a constructor used for initializing this class with RestTemplate but the va