A module to print ASCII histogram.

histogram.lisp

(defpackage #:histogram
  (:use #:cl)
  (:export
   #:print-histogram))
(in-package histogram)


(defun min-value (values)
  "Ищет минимальное по любому количеству элементов."
  (loop for value in values
        minimizing value))


(defun max-value (values)
  "Ищет максимальное по любому количеству элементов."
  (loop for value in values
        maximizing value))


(defun print-histogram (data &key
                               (step 0.1)
                               (width 40) ;; number of symbols in a chart for the largest bucket
                               min-value
                               max-value)
  (let* ((min-value (or min-value
                        (min-value (coerce data 'list))))
         (max-value (or max-value
                        (max-value (coerce data 'list))))
         (num-backets (max 1
                           (ceiling (/ (- max-value min-value)
                                       step))))
         (buckets (make-array num-backets :initial-element 0)))
    
    (flet ((add-value-to-the-bucket (value)
             "Finds a bucket for the value and increments it's counter."
             (let ((index (floor (/ (- value min-value)
                                    step))))
               (incf (aref buckets index))))
           
           (make-bar (number width label)
             "Prints a line filled with = symbol with the label at the end."
             (format t "~4f: ~a ~a~%"
                     number
                     (coerce (make-array width :initial-element #\=)
                             'string)
                     label)))

      ;; Now add all data points to their buckets
      (mapc #'add-value-to-the-bucket
            (coerce data 'list))

      ;; And print bucket values as a ASCII chart
      (let ((max-bucket-size
              (apply #'max (coerce buckets 'list))))
        (loop for value across buckets
              for number from min-value to max-value by step
              do (make-bar number
                           (floor (* (/ value max-bucket-size)
                                     width))
                           value))))))

Suggestion:

(defun min-value (values)
  (apply #'min values))

(defun max-value (values)
  (apply #'max values))

You even use this elsewhere in the code!

Good idea! Thank you! чт, 25 июл. 2019 г., 13:08 Chris <notifications@github.com>:

…

Suggestion: (defun min-value (values) (apply #'min values)) (defun max-value (values) (apply #'max values)) You even use this elsewhere in the code! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://gist.github.com/57739e2238485a83a9d7e01dbcda09dd?email_source=notifications&email_token=AAAGB67JA7X66OFJ4IGX5JLQBF3QJA5CNFSM4IGZA5Q2YY3PNVWWK3TUL52HS4DFVNDWS43UINXW23LFNZ2KUY3PNVWWK3TUL5UWJTQAFV5FS#gistcomment-2980441>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAGB62YYQ4HAGTSHHQG523QBF3QJANCNFSM4IGZA5QQ> .