detach.cgi/detachall.cgi
- There's some tricky file and pipe related stuff in here, that I'm not confident I haven't broken, and don't know how to test.
- Particularly the $buf in while loop thing
export.cgi
- %done is in the right scope, and doesn't need to be our?
mailsearch.cgi
- Has a lot of variables used across blocks. I may have made a mistake or two in scoping too tightly.
mailbox-lib.pl
- line 150 $body is defined, and possibly populated in the next conditional block, but seems to have nothing done with it. seems bug-like.
- line 1806, seems to need these as globals...not sure about $expanded.
- BUG: 1054, 1063, $file is undefined. Probably should be $ifile, or not there, at all?
- 1319: $acptip is undefined. Looks like it is defined in miniserv, but not made public with our. Is defined with local.
- BUG? 1738, 1759, 1765, 1784, in show_mailbox_buttons, @mail is undefined. Where should that come from?
- 2217 $qid is undefined, 2218 $subs is undefined
reply_mail.cgi
- is terrifying
save_comp.cgi
- 26, make sure my $n is right in that spot...potentially a scope problem?
view_mail.cgi
- BUG: $sindex is undefined. It gets defined locally in mailbox-lib.pl, but is private.
- BUG: 366, 376 $dsntm is defined but unused