Created
March 3, 2012 21:34
-
-
Save tbielawa/1968419 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addition of mml-quote-region (notmuch-mua.el) in 2c6710e3 breaks | |
automatic signing in replies. When replies are mml-quoted and signing | |
is enabled by default the "<#part sign=pgpmime>" string will appear on | |
line 1. This will be consumed during the application of the | |
mml-quote-region function and transform into the inert string | |
"<#!part sign=pgpmime>". The result is that responses will no longer | |
be signed by default. | |
This fix moves the point forward one line before applying the quoting | |
function. | |
Consideration: Clients not signing mail by default. The first line of | |
their responses would be skipped when the quoting function is | |
applied. This string takes this general form: | |
On Sat, 03 Mar 2012 12:55:14 -0800, notmuch-request@notmuchmail.org wrote: | |
Because the string is generated by notmuch I don't believe this fix | |
introduces the possibility for malicious mml commands being omitted | |
from the quoting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment