Skip to content

Instantly share code, notes, and snippets.

@tcosentino
Created March 28, 2013 06:59
Show Gist options
  • Save tcosentino/5261230 to your computer and use it in GitHub Desktop.
Save tcosentino/5261230 to your computer and use it in GitHub Desktop.

###Just a few notes about the code you sent:

  1. I have heard/read that the 'mysql' family of php functions are being sort of phased out. mysqli is replacing it, as well as other things like PDO. I think it would be good practice/best if you switched it to PDO because thats what we use with the rest of the site.
  • PDO lets you make it more object oriented
  1. in updateAd all of the 'else' have set schoolID when they shouldn't
  • $titleUpdate = "UPDATE deal SET schoolID='$dateEnd' WHERE id=$desired";
  1. On every page you need to check if there is a valid session, and if not don't allow them to see the page
  2. Other than that -- most things look pretty good. I will run it tomorrow, and see if I can brake it anywhere haha.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment