tcosentino

####Charts Development

---

#####Session ID It was not clear to me where this is to come from. Grep'ing for it on the source revealed a lot of hard coded versions of it. For the moment, it is hard coded at the top of charts.render.

#####URL Roots (Chart-Server/Chart-Images) There are currently two hard coded url roots. My assumption is these will be handled by some type of configuration file. Has this been defined as yet?

#####CSS: Created charts.scss with two simple classes.

tcosentino

The tree layout implements the Reingold-Tilford algorithm for efficient, tidy arrangement of layered nodes. The depth of nodes is computed by distance from the root, leading to a ragged appearance. Cartesian orientations are also supported. Implementation based on work by Jeff Heer and Jason Davies using Buchheim et al.'s linear-time variant of the Reingold-Tilford algorithm. Data shows the Flare class hierarchy, also courtesy Jeff Heer.

tcosentino

###Just a few notes about the code you sent:

1. I have heard/read that the 'mysql' family of php functions are being sort of phased out. mysqli is replacing it, as well as other things like PDO. I think it would be good practice/best if you switched it to PDO because thats what we use with the rest of the site.

• PDO lets you make it more object oriented

2. in updateAd all of the 'else' have set schoolID when they shouldn't

• $titleUpdate = "UPDATE deal SET schoolID='$dateEnd' WHERE id=$desired";

3. On every page you need to check if there is a valid session, and if not don't allow them to see the page
4. Other than that -- most things look pretty good. I will run it tomorrow, and see if I can brake it anywhere haha.