Skip to content

Instantly share code, notes, and snippets.

@teimurjan

teimurjan/sametrica-code-review-03-10-2017.md

Last active October 3, 2017 04:57
Show Gist options
  • Save teimurjan/bf5f6b16abdfb41d5b6bff72e6693476 to your computer and use it in GitHub Desktop.
Save teimurjan/bf5f6b16abdfb41d5b6bff72e6693476 to your computer and use it in GitHub Desktop.
Download ZIP
Form Edit, Teimur Gasanov
Raw
sametrica-code-review-03-10-2017.md

Form Edit

  • Exract EditTab to a container in order to not sending props from the parent.
  • Make components stateless
  • Refactor tabs
  • Extract spinner to a wrapper
  • Make files/variables names more clear
  • Extract language to the FornEdit global state

Edit tab

  • Remove unnecessary handlers
  • Extract switch to a factory
  • Remove empty method for question onChange
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment