Skip to content

Instantly share code, notes, and snippets.

@tejal29

tejal29/shell

Created March 4, 2019 21:01
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save tejal29/96958f32ea88cecd6cbe5edd26c68968 to your computer and use it in GitHub Desktop.
Save tejal29/96958f32ea88cecd6cbe5edd26c68968 to your computer and use it in GitHub Desktop.
Download ZIP
Timing for skaffold init for 4K github repo
Raw
shell
tejaldesai@tejaldesai~/go/src/github.com/soullivaneuh/skaffold-issues: (issue-1651)$ ../../GoogleContainerTools/skaffold/out/skaffold init -v=debug
INFO[0000] Skaffold &{Version:v0.5.0-1901-g2aa1814e-dirty ConfigVersion:skaffold/v1beta6 GitVersion: GitCommit:2aa1814e8dc49f934565460b1fa25ce068ac9b85 GitTreeState:dirty BuildDate:2019-03-04T12:59:14Z GoVersion:go1.12rc1 Compiler:gc Platform:linux/amd64}
DEBU[0000] Update check not enabled, skipping.
DEBU[0000] skip walking hidden dir .git
INFO[0000] time elapsed 185.753µs
FATA[0000] one or more valid Dockerfiles must be present to run skaffold; please provide at least one Dockerfile and try again
tejaldesai@tejaldesai~/go/src/github.com/soullivaneuh/skaffold-issues: (issue-1651)$
../../GoogleContainerTools/skaffold/out/skaffold init -v=debug
INFO[0000] Skaffold &{Version:v0.5.0-1901-g1d077079-dirty ConfigVersion:skaffold/v1beta6 GitVersion: GitCommit:1d077079b616e7468ba72008ea39be4cf220c83a GitTreeState:dirty BuildDate:2019-03-04T13:00:49Z GoVersion:go1.12rc1 Compiler:gc Platform:linux/amd64}
DEBU[0000] Update check not enabled, skipping.
INFO[0000] time elapsed 1.324864ms
FATA[0000] one or more valid Dockerfiles must be present to run skaffold; please provide at least one Dockerfile and try again
tejaldesai@tejaldesai~/go/src/github.com/soullivaneuh/skaffold-issues: (issue-1651)$
@tejal29
Copy link
Author

tejal29 commented Mar 4, 2019 •
edited

Performance improvement on branch:
Repo: https://github.com/soullivaneuh/skaffold-issues.git
Branch: issue-1651

Time with old tool = 1.324ms
Time with perf patch = 0.185ms

Improvement = 1.324 - 0.185 = 1.139
% improvement = 1.139/1.324 *100 = 86%

Note: As code size gets larger, this improvement will reduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment