Skip to content

Instantly share code, notes, and snippets.

@theblockstalk
Created May 11, 2018 09:38
Show Gist options
  • Save theblockstalk/9ca2a46462a15f9c3cbf27ba832d2ed6 to your computer and use it in GitHub Desktop.
Save theblockstalk/9ca2a46462a15f9c3cbf27ba832d2ed6 to your computer and use it in GitHub Desktop.
this is a casual review only of the contract https://github.com/samistart/EFLD10Coin/blob/master/EFLD10Coin.sol
this is not a commercial review
at commit 8bca4279b0ec2e81c1092574ccfd7130078dcff0 by Jack Tanner
### major issues
1. none
### minor issues:
1. pass 0x11f9cEd89E64ea505eE44D07Ea49848522729ba3 in as constructor argument instead
2. using address(0) is ok. Usnig the address of a suicided contract is better IM
https://ethereum.stackexchange.com/questions/16188/best-way-to-burn-ethers-and-other-ethereum-tokens/16190#16190
3. consider using a library for SafeMath instead of contract
4. consider using whenNotPaused modifier of Pausable for transfer() and transferFrom() to allow for easier upgradeablitiy (albeit manual) if needed.
https://github.com/OpenZeppelin/openzeppelin-solidity/blob/master/contracts/lifecycle/Pausable.sol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment