Skip to content

Instantly share code, notes, and snippets.

@themeblvd
Last active December 16, 2015 08:59
Show Gist options
  • Save themeblvd/5409584 to your computer and use it in GitHub Desktop.
Save themeblvd/5409584 to your computer and use it in GitHub Desktop.
Here's what I'm doing. Let me know if this isn't happening for you.
1) Add more than one upload option to the options page.
2) Upload and insert an image on any of the upload options.
3) Go to another one of the upload options. -- Now here, when I select the image and
insert it, it inserts properly, but modal window does not close. I have to "X" out of it.
-- This seems to be something with how you're binding remove/upload actions upon changing
the button. Can you reproduce this? I'm using latest Chrome and Firefox.
@devinsays
Copy link

You're not crazy. I verified the bug in both the theme version and plugin version.

For some reason frame.close(); on line 36 is not actually closing the window.

console.log(frame); shows that a unique window is used.

I have this starred. Will need to look into it when I have more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment