Skip to content

Instantly share code, notes, and snippets.

Show Gist options
  • Save theonlyrao/8a30a6732b3baffbdb57cc2e6ae3b96f to your computer and use it in GitHub Desktop.
Save theonlyrao/8a30a6732b3baffbdb57cc2e6ae3b96f to your computer and use it in GitHub Desktop.
ashwin-mock-assessment-submission.markdown
@joshuajhun
Copy link

  1. Satisfactory Progress
    2: Developer completes iterations 1 through 5 with some bugs or missing functionality.

  2. Ruby Syntax & Style

    3: Developer is able to write idiomatic and effective Ruby. Application makes good use of Object-Oriented modeling with few gaps in class identification and component extraction. Developer can speak to choices made in the code and knows what every line of code is doing.

  3. Rails Style & API
    3: Developer generally writes clean Rails features that make smart use of Ruby, with some struggles in pushing logic down the stack. The application displays good judgement in modeling the problem as data. Developer can speak to choices made in the code and knows what every line of code is doing.

  4. Javascript Syntax & Style

    2.5: Developer can accomplish basic tasks with Javascript but implementation is largely copy/pasted or non-idiomatic. Developer is not confident in what every line of the code is doing or cannot speak to the choices made.

  5. Testing

    4: Developer excels at taking small steps and using the tests for both design and verification. Developer uses integration tests, controller tests, and model tests where appropriate.

  6. User Interface

    3: The application has many strong pages/interactions, but a few holes in lesser-used functionality

  7. Workflow

    4: The developer effectively uses Git branches and many small, atomic commits that document the evolution of their application.

Feedback

  • javascript could be cleaned up and refactored
  • developer did a great job testing and leveraging integration tests with selenium
  • finish implementing some of the base functionality.

@rrgayhart
Copy link

Satisfactory Progress bumped up to a 4 (visuals pretty amazing/ great UX/UI)

JavaScript bumped up to a 3

User Interface bumped from 3 to 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment