Skip to content

Instantly share code, notes, and snippets.

@thetallweeks
Created December 1, 2015 01:42
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save thetallweeks/afb29eab2333b8ba5981 to your computer and use it in GitHub Desktop.
Save thetallweeks/afb29eab2333b8ba5981 to your computer and use it in GitHub Desktop.
// currently
function update(id, deployment, local) {
var deferred = $q.defer(),
d = $q.defer();
if (!local) {
$http.patch('/api/deployments/' + id, deployment).success(function (data) {
if (_.isObject(data)) {
d.resolve(deployment);
} else {
deferred.reject(data);
}
}).error(function () {
deferred.reject();
});
} else {
d.resolve(deployment);
}
d.promise.then(function (deployment) {
var idx = _.findIndex(scope.deployments, { id: id });
var full = _.extend({ id: id }, deployment);
scope.deployments[idx] = full;
var cloned = _.cloneDeep(full);
deferred.resolve(cloned);
$rootScope.$emit('deploymentsService.update', id, cloned);
});
return deferred.promise;
}
// can be written as
function update(id, deployment, local) {
return !local ? cache.set(deployment, { sync: true }) : cache.set(deployment);
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment