Last active
January 2, 2016 18:19
-
-
Save tjfontaine/8342543 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From 270c2deb84b04b508c9d90f58684ee5bf7b3dbca Mon Sep 17 00:00:00 2001 | |
From: Timothy J Fontaine <tjfontaine@gmail.com> | |
Date: Thu, 9 Jan 2014 13:33:51 -0800 | |
Subject: [PATCH] src: OnFatalError handler must abort() | |
We are in an unrecoverable state if v8 throws a FatalError, actually | |
ask the operating system to dump core in this case. | |
Fixes #6836 | |
--- | |
src/node.cc | 2 +- | |
test/simple/test-abort-fatal-error.js | 39 +++++++++++++++++++++++++++++++++++ | |
2 files changed, 40 insertions(+), 1 deletion(-) | |
create mode 100644 test/simple/test-abort-fatal-error.js | |
diff --git a/src/node.cc b/src/node.cc | |
index 47a7d5e..a18e0d8 100644 | |
--- a/src/node.cc | |
+++ b/src/node.cc | |
@@ -1914,7 +1914,7 @@ static void OnFatalError(const char* location, const char* message) { | |
} else { | |
fprintf(stderr, "FATAL ERROR: %s\n", message); | |
} | |
- exit(5); | |
+ abort(); | |
} | |
void FatalException(TryCatch &try_catch) { | |
diff --git a/test/simple/test-abort-fatal-error.js b/test/simple/test-abort-fatal-error.js | |
new file mode 100644 | |
index 0000000..81c4ca5 | |
--- /dev/null | |
+++ b/test/simple/test-abort-fatal-error.js | |
@@ -0,0 +1,39 @@ | |
+// Copyright Joyent, Inc. and other Node contributors. | |
+ | |
+// Permission is hereby granted, free of charge, to any person obtaining a | |
+// copy of this software and associated documentation files (the | |
+// "Software"), to deal in the Software without restriction, including | |
+// without limitation the rights to use, copy, modify, merge, publish, | |
+// distribute, sublicense, and/or sell copies of the Software, and to permit | |
+// persons to whom the Software is furnished to do so, subject to the | |
+// following conditions: | |
+ | |
+// The above copyright notice and this permission notice shall be included | |
+// in all copies or substantial portions of the Software. | |
+ | |
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS | |
+// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF | |
+// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN | |
+// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, | |
+// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR | |
+// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE | |
+// USE OR OTHER DEALINGS IN THE SOFTWARE. | |
+ | |
+var assert = require('assert'); | |
+var common = require('../common'); | |
+ | |
+if (process.platform === 'win32') { | |
+ console.log('skipping test on windows'); | |
+ process.exit(0); | |
+} | |
+ | |
+var exec = require('child_process').exec; | |
+ | |
+var cmdline = 'ulimit -c 0; ' + process.execPath; | |
+cmdline += ' --max-old-space-size=1 --max-new-space-size=1'; | |
+cmdline += ' -e "setInterval(function() { new Buffer(1024); }, 1);"'; | |
+ | |
+exec(cmdline, function(err, stdout, stderr) { | |
+ assert(err); | |
+ assert(stderr.toString().match(/abort/i)); | |
+}); | |
-- | |
1.8.3.4 (Apple Git-47) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment