Created
July 6, 2016 21:23
-
-
Save tkruse/7e9b71eca7c01fb015a529676e3c8255 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git a/samples/chromium-sample/simple.def b/samples/chromium-sample/simple.def | |
index 96b57ee..d9a98b7 100644 | |
--- a/samples/chromium-sample/simple.def | |
+++ b/samples/chromium-sample/simple.def | |
@@ -3,7 +3,6 @@ src/* | |
src/chrome_content_renderer_client.cc:113: Include the directory when naming .h files [build/include_subdir] [4] | |
src/chrome_content_renderer_client.cc:1156: Use int16/int64/etc, rather than the C type long [runtime/int] [4] | |
src/chrome_content_renderer_client.cc:1161: Use int16/int64/etc, rather than the C type long [runtime/int] [4] | |
-src/chrome_content_renderer_client.cc:5: samples/chromium-sample/src/chrome_content_renderer_client.cc should include its header file samples/chromium-sample/src/chrome_cont | |
ent_renderer_client.h [build/include] [5] | |
Done processing src/chrome_content_renderer_client.cc | |
src/chrome_content_renderer_client.h:5: #ifndef header guard has wrong style, please use: SAMPLES_CHROMIUM_SAMPLE_SRC_CHROME_CONTENT_RENDERER_CLIENT_H_ [build/header_guard] | |
[5] | |
src/chrome_content_renderer_client.h:225: #endif line should be "#endif // SAMPLES_CHROMIUM_SAMPLE_SRC_CHROME_CONTENT_RENDERER_CLIENT_H_" [build/header_guard] [5] | |
@@ -12,10 +11,8 @@ src/chrome_content_renderer_client.h:117: Use int16/int64/etc, rather than the | |
Done processing src/chrome_content_renderer_client.h | |
src/io_thread.cc:1148: Closing ) should be moved to the previous line [whitespace/parens] [2] | |
src/io_thread.cc:1547: Missing space around colon in range-based for loop [whitespace/forcolon] [2] | |
-src/io_thread.cc:5: samples/chromium-sample/src/io_thread.cc should include its header file samples/chromium-sample/src/io_thread.h [build/include] [5] | |
Done processing src/io_thread.cc | |
src/io_thread.h:5: #ifndef header guard has wrong style, please use: SAMPLES_CHROMIUM_SAMPLE_SRC_IO_THREAD_H_ [build/header_guard] [5] | |
src/io_thread.h:565: #endif line should be "#endif // SAMPLES_CHROMIUM_SAMPLE_SRC_IO_THREAD_H_" [build/header_guard] [5] | |
Done processing src/io_thread.h | |
-Total errors found: 13 | |
- | |
+Total errors found: 11 | |
diff --git a/samples/codelite-sample/simple.def b/samples/codelite-sample/simple.def | |
index 8b04b1f..68bec5b 100644 | |
--- a/samples/codelite-sample/simple.def | |
+++ b/samples/codelite-sample/simple.def | |
@@ -599,9 +599,6 @@ src/pptable.cpp:660: Tab found; better to use spaces [whitespace/tab] [1] | |
src/pptable.cpp:661: Tab found; better to use spaces [whitespace/tab] [1] | |
src/pptable.cpp:662: Tab found; better to use spaces [whitespace/tab] [1] | |
src/pptable.cpp:663: Tab found; better to use spaces [whitespace/tab] [1] | |
-src/pptable.cpp:526: Add #include <map> for map<> [build/include_what_you_use] [4] | |
-src/pptable.cpp:592: Add #include <vector> for vector<> [build/include_what_you_use] [4] | |
-src/pptable.cpp:648: Add #include <string> for string [build/include_what_you_use] [4] | |
Done processing src/pptable.cpp | |
src/pptable.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] | |
src/pptable.h:1: #ifndef header guard has wrong style, please use: SAMPLES_CODELITE_SAMPLE_SRC_PPTABLE_H_ [build/header_guard] [5] | |
diff --git a/samples/protobuf-sample/simple.def b/samples/protobuf-sample/simple.def | |
index 506ce7a..c233aeb 100644 | |
--- a/samples/protobuf-sample/simple.def | |
+++ b/samples/protobuf-sample/simple.def | |
@@ -1620,7 +1620,6 @@ src/descriptor.pb.cc:15142: Lines should be <= 80 characters long [whitespace/ | |
src/descriptor.pb.cc:15146: Lines should be <= 80 characters long [whitespace/line_length] [2] | |
src/descriptor.pb.cc:15150: Lines should be <= 80 characters long [whitespace/line_length] [2] | |
src/descriptor.pb.cc:15155: Lines should be <= 80 characters long [whitespace/line_length] [2] | |
-src/descriptor.pb.cc:5: samples/protobuf-sample/src/descriptor.pb.cc should include its header file samples/protobuf-sample/src/descriptor.pb.h [build/include] [5] | |
Done processing src/descriptor.pb.cc | |
src/descriptor.pb.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] | |
src/descriptor.pb.h:4: #ifndef header guard has wrong style, please use: SAMPLES_PROTOBUF_SAMPLE_SRC_DESCRIPTOR_PB_H_ [build/header_guard] [5] | |
diff --git a/samples/silly-sample/simple.def b/samples/silly-sample/simple.def | |
index da60756..271c590 100644 | |
--- a/samples/silly-sample/simple.def | |
+++ b/samples/silly-sample/simple.def | |
@@ -106,10 +106,5 @@ src/sillycode.cpp:252: Tab found; better to use spaces [whitespace/tab] [1] | |
src/sillycode.cpp:252: At least two spaces is best between code and comments [whitespace/comments] [2] | |
src/sillycode.cpp:255: Empty loop bodies should use {} or continue [whitespace/empty_loop_body] [5] | |
src/sillycode.cpp:255: At least two spaces is best between code and comments [whitespace/comments] [2] | |
-src/sillycode.cpp:9: Add #include <vector> for vector<> [build/include_what_you_use] [4] | |
-src/sillycode.cpp:121: Add #include <algorithm> for swap [build/include_what_you_use] [4] | |
-src/sillycode.cpp:219: Add #include <limits> for numeric_limits<> [build/include_what_you_use] [4] | |
-src/sillycode.cpp:232: Add #include <string> for string [build/include_what_you_use] [4] | |
Done processing src/sillycode.cpp | |
-Total errors found: 115 | |
- | |
+Total errors found: 106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment