Avoid finalizer problems with JMocks SingleThreadedPolicy

gistfile1.java

    public static class SingleThreadedPolicyAvoidingFinaliseProblems extends SingleThreadedPolicy {
        @Override
        public Invokable synchroniseAccessTo(final Invokable mockObject) {
            final Invokable synchronizedMockObject = super.synchroniseAccessTo(mockObject);
            return new Invokable() {
                @Override
                public Object invoke(Invocation invocation) throws Throwable {
                    if (Thread.currentThread().getName().equalsIgnoreCase("Finalizer"))
                        return mockObject.invoke(invocation);
                    return synchronizedMockObject.invoke(invocation);
                }
            };
        }
    }

Avoid's spurious errors like the following, where the synchroniser is correctly detecting invocation to a mockery but for some reason, this is from a finalizer thread (and so not really a genuine error).

2012-05-31 08:35:35,283 ERROR Finalizer [Console$Logger] - the Mockery is not thread-safe: use a Synchroniser to ensure thread safety

See bug report JMOCK-256 and on Github #36

Bit of an improvment

public static class SingleThreadedPolicyAvoidingFinaliseProblems extends SingleThreadedPolicy {
    @Override
    public Invokable synchroniseAccessTo(Invokable unsynchronizedInvocation) {
        Invokable synchronizedInvocation = super.synchroniseAccessTo(unsynchronizedInvocation);
        return new InvokeBasedOnCurrentThreadBeingTheFinalizerThread(unsynchronizedInvocation, synchronizedInvocation);
    }
}

private static class InvokeBasedOnCurrentThreadBeingTheFinalizerThread implements Invokable {

    private final Invokable whenOnFinalizerThread;
    private final Invokable whenNotFinalizerThread;

    public InvokeBasedOnCurrentThreadBeingTheFinalizerThread(Invokable whenOnFinalizerThread, Invokable whenNotFinalizerThread) {
        this.whenOnFinalizerThread = whenOnFinalizerThread;
        this.whenNotFinalizerThread = whenNotFinalizerThread;
    }

    @Override
    public Object invoke(Invocation invocation) throws Throwable {
        if (currentThreadIs("Finalizer"))
            return whenOnFinalizerThread.invoke(invocation);
        return whenNotFinalizerThread.invoke(invocation);
    }

    private static boolean currentThreadIs(String name) {
        return Thread.currentThread().getName().equalsIgnoreCase(name);
    }
}