Created
February 18, 2011 09:13
-
-
Save tomafro/833444 to your computer and use it in GitHub Desktop.
Experimental Mongo Instrumentation for Rails 3
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
module Mongo | |
module Instrumentation | |
def self.instrument(clazz, *methods) | |
clazz.module_eval do | |
methods.each do |m| | |
class_eval %{def #{m}_with_instrumentation(*args, &block) | |
ActiveSupport::Notifications.instrumenter.instrument "mongo.mongo", :name => "#{m}" do | |
#{m}_without_instrumentation(*args, &block) | |
end | |
end | |
} | |
alias_method_chain m, :instrumentation | |
end | |
end | |
end | |
class Railtie < Rails::Railtie | |
initializer "mongo.instrumentation" do |app| | |
Mongo::Instrumentation.instrument Mongo::Connection, :send_message, :send_message_with_safe_check, :receive_message | |
#Mongo::Instrumentation.instrument Mongo::Collection, :find, :save, :insert, :update | |
#Mongo::Instrumentation.instrument Mongo::DB, :command | |
ActiveSupport.on_load(:action_controller) do | |
include Mongo::Instrumentation::ControllerRuntime | |
end | |
Mongo::Instrumentation::LogSubscriber.attach_to :mongo | |
end | |
end | |
module ControllerRuntime | |
extend ActiveSupport::Concern | |
protected | |
attr_internal :mongo_runtime | |
def cleanup_view_runtime | |
mongo_rt_before_render = Mongo::Instrumentation::LogSubscriber.reset_runtime | |
runtime = super | |
mongo_rt_after_render = Mongo::Instrumentation::LogSubscriber.reset_runtime | |
self.mongo_runtime = mongo_rt_before_render + mongo_rt_after_render | |
runtime - mongo_rt_after_render | |
end | |
def append_info_to_payload(payload) | |
super | |
payload[:mongo_runtime] = mongo_runtime | |
end | |
module ClassMethods | |
def log_process_action(payload) | |
messages, mongo_runtime = super, payload[:mongo_runtime] | |
messages << ("Mongo: %.1fms" % mongo_runtime.to_f) if mongo_runtime | |
messages | |
end | |
end | |
end | |
class LogSubscriber < ActiveSupport::LogSubscriber | |
def self.runtime=(value) | |
Thread.current["mongo_mongo_runtime"] = value | |
end | |
def self.runtime | |
Thread.current["mongo_mongo_runtime"] ||= 0 | |
end | |
def self.reset_runtime | |
rt, self.runtime = runtime, 0 | |
rt | |
end | |
def mongo(event) | |
self.class.runtime += event.duration | |
end | |
end | |
end | |
end |
My bad. An extra comma creeped in there when I cut and paste into the gist. Should work now (I'm on 3.0.3 too)
That's working for me. Yep, the stats seem much more realistic with this change (around 10 * more than before). Thanks!
This is great. I was just about to suggest not instrumenting :find :save :insert :update, but you beat me to it. Thanks! I hope you comment every time you make an improvement.
This code is now a gem, 'mongo-rails-instrumentation', and available on github here: https://github.com/tomafro/mongo-rails-instrumentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm getting a "block not supplied" argument error on rails 3.0.3? What version are you on?