hashicorp/terraform-provider-azurerm#199 Linux Terraform Configuration

linux.tf

variable "prefix" {
  default = "issue199"
}

variable "configuration_json" {
  default = "{\"diagnosticMonitorConfiguration\":{\"metrics\":{\"resourceId\":\"%VirtualMachineResourceId%\",\"metricAggregation\":[{\"scheduledTransferPeriod\":\"PT1H\"},{\"scheduledTransferPeriod\":\"PT1M\"}]},\"performanceCounters\":{\"performanceCounterConfiguration\":[{\"class\":\"Memory\",\"counterSpecifier\":\"PercentAvailableMemory\",\"table\":\"LinuxMemory\"},{\"class\":\"Memory\",\"counterSpecifier\":\"AvailableMemory\",\"table\":\"LinuxMemory\"},{\"class\":\"Memory\",\"counterSpecifier\":\"UsedMemory\",\"table\":\"LinuxMemory\"},{\"class\":\"Memory\",\"counterSpecifier\":\"PercentUsedSwap\",\"table\":\"LinuxMemory\"},{\"class\":\"Processor\",\"counterSpecifier\":\"PercentProcessorTime\",\"table\":\"LinuxCpu\"},{\"class\":\"Processor\",\"counterSpecifier\":\"PercentIOWaitTime\",\"table\":\"LinuxCpu\"},{\"class\":\"Processor\",\"counterSpecifier\":\"PercentIdleTime\",\"table\":\"LinuxCpu\"},{\"class\":\"PhysicalDisk\",\"counterSpecifier\":\"AverageWriteTime\",\"table\":\"LinuxDisk\"},{\"class\":\"PhysicalDisk\",\"counterSpecifier\":\"AverageReadTime\",\"table\":\"LinuxDisk\"},{\"class\":\"PhysicalDisk\",\"counterSpecifier\":\"ReadBytesPerSecond\",\"table\":\"LinuxDisk\"},{\"class\":\"PhysicalDisk\",\"counterSpecifier\":\"WriteBytesPerSecond\",\"table\":\"LinuxDisk\"}]}}}"
}

resource "azurerm_resource_group" "test" {
  name     = "${var.prefix}-dev"
  location = "West Europe"
}

resource "azurerm_virtual_network" "test" {
  name                = "${var.prefix}vn"
  address_space       = ["10.0.0.0/16"]
  location            = "${azurerm_resource_group.test.location}"
  resource_group_name = "${azurerm_resource_group.test.name}"
}

resource "azurerm_subnet" "test" {
  name                 = "main"
  resource_group_name  = "${azurerm_resource_group.test.name}"
  virtual_network_name = "${azurerm_virtual_network.test.name}"
  address_prefix       = "10.0.2.0/24"
}

resource "azurerm_network_interface" "test" {
  name                = "${var.prefix}-ni"
  location            = "${azurerm_resource_group.test.location}"
  resource_group_name = "${azurerm_resource_group.test.name}"

  ip_configuration {
    name                          = "testconfiguration1"
    subnet_id                     = "${azurerm_subnet.test.id}"
    private_ip_address_allocation = "dynamic"
  }
}

resource "azurerm_storage_account" "test" {
  name                = "${var.prefix}sa22"
  resource_group_name = "${azurerm_resource_group.test.name}"
  location            = "${azurerm_resource_group.test.location}"
  account_type        = "Standard_LRS"

  tags {
    environment = "staging"
  }
}

resource "azurerm_virtual_machine" "test" {
  name                  = "${var.prefix}-vm"
  location              = "${azurerm_resource_group.test.location}"
  resource_group_name   = "${azurerm_resource_group.test.name}"
  network_interface_ids = ["${azurerm_network_interface.test.id}"]
  vm_size               = "Standard_DS1_v2"

  storage_image_reference {
    publisher = "Canonical"
    offer     = "UbuntuServer"
    sku       = "14.04.5-LTS"
    version   = "latest"
  }

  storage_os_disk {
    name              = "myosdisk1"
    caching           = "ReadWrite"
    create_option     = "FromImage"
    managed_disk_type = "Standard_LRS"
  }

  os_profile {
    computer_name  = "hostname"
    admin_username = "testadmin"
    admin_password = "Password1234!"
  }

  os_profile_linux_config {
    disable_password_authentication = false
  }

  tags {
    environment = "staging"
  }
}

data "template_file" "xml" {
  template = "${file("template.xml.tpl")}"

  vars {
    virtual_machine_id = "${azurerm_virtual_machine.test.id}"
  }
}

resource "azurerm_virtual_machine_extension" "test" {
  name                 = "hostname"
  location             = "${azurerm_resource_group.test.location}"
  resource_group_name  = "${azurerm_resource_group.test.name}"
  virtual_machine_name = "${azurerm_virtual_machine.test.name}"
  publisher            = "Microsoft.OSTCExtensions"
  type                 = "LinuxDiagnostic"
  type_handler_version = "2.3"

  settings = <<SETTINGS
    {
        "ladCfg": "${base64encode(var.configuration_json)}",
        "storageAccount": "${azurerm_storage_account.test.name}"
    }
SETTINGS

  protected_settings = <<SETTINGS
    {
        "storageAccountName": "${azurerm_storage_account.test.name}",
        "storageAccountKey": "${azurerm_storage_account.test.primary_access_key}"
    }
SETTINGS

  tags {
    environment = "Production"
  }
}

I tried extend my Terraform based on your example. I see it changed something

 protected_settings: "<sensitive>" => "<sensitive>"
  settings:           "" => "    {\n        \"ladCfg\": \"eyJkaWFnbm9zdGljTW9uaXRvckNvbmZpZ3VyYXRpb24iOnsibWV0cmljcyI6eyJyZXNvdXJjZUlkIjoiJVZpcnR1YWxNYWNoaW5lUmVzb3VyY2VJZCUiLCJtZXRyaWNBZ2dyZWdhdGlvbiI6W3sic2NoZWR1bGVkVHJhbnNmZXJQZXJpb2QiOiJQVDFIIn0seyJzY2hlZHVsZWRUcmFuc2ZlclBlcmlvZCI6IlBUMU0ifV19LCJwZXJmb3JtYW5jZUNvdW50ZXJzIjp7InBlcmZvcm1hbmNlQ291bnRlckNvbmZpZ3VyYXRpb24iOlt7ImNsYXNzIjoiTWVtb3J5IiwiY291bnRlclNwZWNpZmllciI6IlBlcmNlbnRBdmFpbGFibGVNZW1vcnkiLCJ0YWJsZSI6IkxpbnV4TWVtb3J5In0seyJjbGFzcyI6Ik1lbW9yeSIsImNvdW50ZXJTcGVjaWZpZXIiOiJBdmFpbGFibGVNZW1vcnkiLCJ0YWJsZSI6IkxpbnV4TWVtb3J5In0seyJjbGFzcyI6Ik1lbW9yeSIsImNvdW50ZXJTcGVjaWZpZXIiOiJVc2VkTWVtb3J5IiwidGFibGUiOiJMaW51eE1lbW9yeSJ9LHsiY2xhc3MiOiJNZW1vcnkiLCJjb3VudGVyU3BlY2lmaWVyIjoiUGVyY2VudFVzZWRTd2FwIiwidGFibGUiOiJMaW51eE1lbW9yeSJ9LHsiY2xhc3MiOiJQcm9jZXNzb3IiLCJjb3VudGVyU3BlY2lmaWVyIjoiUGVyY2VudFByb2Nlc3NvclRpbWUiLCJ0YWJsZSI6IkxpbnV4Q3B1In0seyJjbGFzcyI6IlByb2Nlc3NvciIsImNvdW50ZXJTcGVjaWZpZXIiOiJQZXJjZW50SU9XYWl0VGltZSIsInRhYmxlIjoiTGludXhDcHUifSx7ImNsYXNzIjoiUHJvY2Vzc29yIiwiY291bnRlclNwZWNpZmllciI6IlBlcmNlbnRJZGxlVGltZSIsInRhYmxlIjoiTGludXhDcHUifSx7ImNsYXNzIjoiUGh5c2ljYWxEaXNrIiwiY291bnRlclNwZWNpZmllciI6IkF2ZXJhZ2VXcml0ZVRpbWUiLCJ0YWJsZSI6IkxpbnV4RGlzayJ9LHsiY2xhc3MiOiJQaHlzaWNhbERpc2siLCJjb3VudGVyU3BlY2lmaWVyIjoiQXZlcmFnZVJlYWRUaW1lIiwidGFibGUiOiJMaW51eERpc2sifSx7ImNsYXNzIjoiUGh5c2ljYWxEaXNrIiwiY291bnRlclNwZWNpZmllciI6IlJlYWRCeXRlc1BlclNlY29uZCIsInRhYmxlIjoiTGludXhEaXNrIn0seyJjbGFzcyI6IlBoeXNpY2FsRGlzayIsImNvdW50ZXJTcGVjaWZpZXIiOiJXcml0ZUJ5dGVzUGVyU2Vjb25kIiwidGFibGUiOiJMaW51eERpc2sifV19fX0=\",\n        \"storageAccount\": \"intr3storage\"\n    }\n"

but in portal I see:

Your diagnostics extension does not currently have a configuration. One will be generated when saving.

Any advices?

Also do you have an example for version 3.x of diagnostic extension?

I think 'ladCfg' is wrong and it should be 'xmlCfg'.

Actually, 'ladCfg' seems to be OK (https://github.com/Azure/azure-linux-extensions/blob/master/Diagnostic/virtual-machines-linux-diagnostic-extension-v3.md), at least for 3.0. I don't see a reason for the above example to fail.

Now I logged to the machine and see following:

2017/09/18 11:26:24 [Microsoft.OSTCExtensions.LinuxDiagnostic-2.3.9027] Enable,success,0,Invalid mdsd config given. Can't enable.
 This extension install/enable operation is still considered a success as it's an external error. Config validation result: Parse
 reported these messages:
2017/09/18 11:26:24 /var/lib/waagent/Microsoft.OSTCExtensions.LinuxDiagnostic-2.3.9027/./xmlCfg.xml(3) Error: Storage credential
validation for table storage failed: length of base64 string is not an even multiple of 4
2017/09/18 11:26:24 /var/lib/waagent/Microsoft.OSTCExtensions.LinuxDiagnostic-2.3.9027/./xmlCfg.xml(38) Error: No default credent
ials were defined
2017/09/18 11:26:24 /var/lib/waagent/Microsoft.OSTCExtensions.LinuxDiagnostic-2.3.9027/./xmlCfg.xml(43) Error: No default credent
ials were defined
2017/09/18 11:26:24 /var/lib/waagent/Microsoft.OSTCExtensions.LinuxDiagnostic-2.3.9027/./xmlCfg.xml(43) Error: No default credentials were defined
2017/09/18 11:26:24 /var/lib/waagent/Microsoft.OSTCExtensions.LinuxDiagnostic-2.3.9027/./xmlCfg.xml(43) Error: No default credentials were defined
2017/09/18 11:26:24 . Terminating LAD as it can't proceed.

so, the "no default credentials" seems to indicate your protected_settings dont include the storageaccount and storageaccountkey (or possibly the SAS) or maybe not accurately?

protected_settings = {'storageAccountName': sa,
                      'storageAccountKey': sa_key,
                      'storageAcocuntEndPoint': 'https://core.windows.net'}

as for the xmlCfg v ladCfg, yes.. xmlCfg is the way to go and I found this stackoverflow article helpful as that string is base64 encoded.

https://stackoverflow.com/questions/38732786/enable-vm-basic-metrics-via-arm-template

so, just create a VM and enable the diags from the portal, then decode the xmlCfg from base64 and then you understand what it wants for the structure, and config entries.. and voila you should be able to reproduce it from the REST, powershell.. or or or....

HTH

funny note: when you enable the diags from the portal... it creates a "wadcfg" in the XML for a linux system (i would have expected a ladcfg).. go figure. :)

Steven