Skip to content

Instantly share code, notes, and snippets.

@tomleo

tomleo/pr-feedback.md

Last active May 13, 2022 20:46
Show Gist options
  • Save tomleo/ac367c585710407d9bd4e9f44e58d843 to your computer and use it in GitHub Desktop.
Save tomleo/ac367c585710407d9bd4e9f44e58d843 to your computer and use it in GitHub Desktop.
Download ZIP
OIR-Rule of giving feedback
Raw
pr-feedback.md

OIR-Rule of giving feedback

Step 1: Observation

  • neutral
  • generally a statement of fact

Example

This method has 100 lines.

Step 2: Impact

  • impact the observation has on you

Example

This makes it hard for me to grasp the essential logic of this method

Step 3: Request

Use an I-message to express your wish or proposal

Example

I suggest extracting the low-level details into subroutines and give them expressive names

Putting this all togeather

This method has 100 lines. This makes it hard for me to grasp the essential logic of this method. I suggest extracting the low-level details into subroutines and give them expressive names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment