Created
March 14, 2016 10:31
-
-
Save tony2001/391f7728dddeecc8cc34 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/excel.c b/excel.c | |
| index bb4274c..476f9e7 100644 | |
| --- a/excel.c | |
| +++ b/excel.c | |
| @@ -1123,7 +1123,7 @@ EXCEL_METHOD(Book, __construct) | |
| BookHandle book; | |
| zval *object = getThis(); | |
| char *name = NULL, *key; | |
| - int name_len = 0, key_len = 0; | |
| + zend_long name_len = 0, key_len = 0; | |
| zend_bool new_excel = 0; | |
| if (zend_parse_parameters(ZEND_NUM_ARGS(), "|ssb", &name, &name_len, &key, &key_len, &new_excel) == FAILURE) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi @tony2001 why did you change from size_t to zend_long in this case? I just ask because I changed it to size_t and it works for me pretty well. From the php source size_t seems to be apropriate as well... thx