Skip to content

Instantly share code, notes, and snippets.

@torarnv
Created June 2, 2009 13:48
Show Gist options
  • Save torarnv/122240 to your computer and use it in GitHub Desktop.
Save torarnv/122240 to your computer and use it in GitHub Desktop.
commit cc878e32d25c755d953af9d95ca3e9677b3ffdb0
Author: Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Date: Tue Jun 2 15:33:11 2009 +0200
2009-06-02 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Rubber-stamped by Simon Hausmann.
Use File::Spec->tmpdir instead of hardcoded paths for tempfile() dir
This fixes the Windows-build if the user does not have a /tmp directory.
diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
index dfbf00c..ca5e537 100644
--- a/JavaScriptCore/ChangeLog
+++ b/JavaScriptCore/ChangeLog
@@ -1,3 +1,13 @@
+2009-06-02 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Rubber-stamped by Simon Hausmann.
+
+ Use File::Spec->tmpdir instead of hardcoded paths for tempfile() dir
+
+ This fixes the Windows-build if the user does not have a /tmp directory.
+
+ * pcre/dftables:
+
2009-06-02 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver ">>" Hunt.
diff --git a/JavaScriptCore/pcre/dftables b/JavaScriptCore/pcre/dftables
index de2f5bb..8a2d140 100755
--- a/JavaScriptCore/pcre/dftables
+++ b/JavaScriptCore/pcre/dftables
@@ -244,7 +244,7 @@ sub readHeaderValues()
my ($fh, $tempFile) = tempfile(
basename($0) . "-XXXXXXXX",
- DIR => ($ENV{'TMPDIR'} || "/tmp"),
+ DIR => File::Spec->tmpdir,
SUFFIX => ".in",
UNLINK => 0,
);
diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index dc93a97..30d8091 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,13 @@
+2009-06-02 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Rubber-stamped by Simon Hausmann.
+
+ Use File::Spec->tmpdir instead of hardcoded paths for tempfile() dir
+
+ This fixes the Windows-build if the user does not have a /tmp directory.
+
+ * Scripts/bisect-builds:
+
2009-06-01 Yongjun Zhang <yongjun.zhang@nokia.com>>
Reviewed by Holger Freyther. Landed by Adam Barth.
diff --git a/WebKitTools/Scripts/bisect-builds b/WebKitTools/Scripts/bisect-builds
index b1c319f..34230a9 100755
--- a/WebKitTools/Scripts/bisect-builds
+++ b/WebKitTools/Scripts/bisect-builds
@@ -209,7 +209,7 @@ sub createTempFile($)
my ($fh, $tempFile) = tempfile(
basename($0) . "-XXXXXXXX",
- DIR => ($ENV{'TMPDIR'} || "/tmp"),
+ DIR => File::Spec->tmpdir,
SUFFIX => ".html",
UNLINK => 0,
);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment