-
-
Save tuxfight3r/eb85fd230695187a5d21 to your computer and use it in GitHub Desktop.
puppet precomit linting
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#!/bin/bash | |
# pre-commit git hook to check the validity of a puppet manifest | |
# | |
# Prerequisites: | |
# gem install puppet-lint puppet | |
# | |
# Install: | |
# /path/to/repo/.git/hooks/pre-comit | |
# Source RVM if needed | |
[[ -s "$HOME/.rvm/scripts/rvm" ]] && source "$HOME/.rvm/scripts/rvm" # Load RVM into a shell session *as a function* | |
echo "### Checking puppet syntax, for science! ###" | |
# for file in `git diff --name-only --cached | grep -E '\.(pp|erb)'` | |
for file in `git diff --name-only --cached | grep -E '\.(pp)'` | |
do | |
# Only check new/modified files | |
if [[ -f $file ]] | |
then | |
puppet-lint \ | |
--no-80chars-check \ | |
--no-autoloader_layout-check \ | |
--no-nested_classes_or_defines-check \ | |
--no-only_variable_string-check \ | |
--no-2sp_soft_tabs-check \ | |
--with-filename $file | |
# Set us up to bail if we receive any syntax errors | |
if [[ $? -ne 0 ]] | |
then | |
syntax_is_bad=1 | |
else | |
echo "$file looks good" | |
fi | |
fi | |
done | |
echo "" | |
echo "### Checking if puppet manifests are valid ###" | |
# validating the whole manifest takes too long. uncomment this | |
# if you want to test the whole shebang. | |
# for file in `find . -name "*.pp"` | |
# for file in `git diff --name-only --cached | grep -E '\.(pp|erb)'` | |
for file in `git diff --name-only --cached | grep -E '\.(pp)'` | |
do | |
if [[ -f $file ]] | |
then | |
puppet parser validate --mode user $file | |
if [[ $? -ne 0 ]] | |
then | |
echo "ERROR: puppet parser failed at: $file" | |
syntax_is_bad=1 | |
else | |
echo "OK: $file looks valid" | |
fi | |
fi | |
done | |
echo "" | |
if [[ $syntax_is_bad -eq 1 ]] | |
then | |
echo "FATAL: Syntax is bad. See above errors" | |
echo "Bailing" | |
exit 1 | |
else | |
echo "Everything looks good." | |
fi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment