mondo-ingest pull_request_template.md

gistfile1.md

Pre-merge checklist

PR Overview

This PR:

• One
• Two
• Three

=====================

Documentation

• Was the documentation added/updated under docs/?
  • Yes
  • No, updates to the docs were not necessary after careful consideration

QC

• Was the full pipeline run before submitting this PR using sh run.sh make build-mondo-ingest on this branch (after docker pull obolibrary/odkfull:dev), and no errors occurred?
  • Yes
  • No, there are no functional (code-related) changes to the pipeline in the PR, so no re-run is necessary

New Packages

• Were any new Python packages added?
  • Yes, requirements.txt.full was updated and an ODK issue submitted
  • No

• Were any other non-Python packages added?
  • Yes, Dockerfile updated and an ODK issue submitted
  • No

PR Review and Conversations Resolved

• Has the PR been sufficiently reviewed by at least one team member of the Mondo Technical team and all threads resolved?
  • Yes
  • No

This is good. Here’s a thought I just had. For each criteria, (Documentation, QC, etc), we either give it options (“radio buttons”), or, if it is simply something that needs to be done with no variability (e.g. PR has been reviewed — we always want it to be reviewed), we can just leave a single checkbox.

Example:

QC

• Yes
• No, there are no functional (code-related) changes to the pipeline in the PR, so no re-run is necessary

PR Review and Conversations Resolved

• Done

Good point to have a Done checkbox (no need to say No, I have not resolved conversations :)

I have not had luck finding a way to use a radio button or anything dynamic so sadly checkboxes it is.

I was concerned this might be too long, but since y'all are both ok with it, I'll make those last updates you suggested later tonight and add that back into the PR

Thank you both!