Skip to content

Instantly share code, notes, and snippets.

@vadym1930
Last active June 20, 2017 21:41
Show Gist options
  • Save vadym1930/29732afc4887ac731acb930f6869247c to your computer and use it in GitHub Desktop.
Save vadym1930/29732afc4887ac731acb930f6869247c to your computer and use it in GitHub Desktop.

Review

Folder structure

  1. The good way of understanding code is separating containers, components, js-components, typo, some partials in own folders or / and files. Sass, (js, if more code) should be separated;
  2. Another bonn tone is dividing source and dest code in own folders.
    src — folder for source stuff: sass, js, images etc.
    dist (dest) — foder for dest stuff: latest minifyied .js .css files
    to some opinion — all files are needed to deploy on the server should be exist in dest(dist) folder

Sass (bad things, recomendations)

  1. Bad way to make spacings with margins, especialy margin-top.
  2. More than 2 nested css selectors.
  3. Better way using fonts instead of png images as icons.
  4. Fonts missed at all.
  5. I don't see container for elements, container must do width of the page-content and padding-left, padding-right across the page.
  6. Input fields shouldn't jump to another line with br, there must be structure that predict labels, errors, inputs.
  7. Where is responsiveness?

gulp stuff

  1. Where is autoprefixer?

UI stuff

  1. Logotype should be a link.
  2. Language buttons doesn't have a hover.
  3. Buttons hover effect couldn't influence on positions of the other elements on a page, height of the button etc.
  4. Background paralax doesn't work.
  5. Scroll isn't convenient.
  6. Scroll pointer is a bit ugly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment