-
-
Save valueof/9a6d60e9c15ac4239b3d to your computer and use it in GitHub Desktop.
A piece of ordinary boilerplate JavaScript code (original.js) rewritten using proposed moustache syntax (moustache.fixed.js) and class syntax as implemented in Traceur (moustache.class.js)
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
class Channel { | |
constructor (opts) { | |
/* ... */ | |
} | |
load () { | |
var widget = document.createElement("iframe"); | |
widget.{ | |
style.{ | |
width = "100%"; | |
border = "none"; | |
overflow = "hidden"; | |
display = "none"; | |
}; | |
dataset.{ | |
disqusUid = this.uid; | |
}; | |
allowTransparency = true; // < IE8 iframe transparency | |
frameBorder = 0; | |
width = "100%"; | |
id = "dsq" + this.uid; | |
src = this.target + "#" + this.uid; | |
}; | |
} | |
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var Channel = function (opts) { /* ... */ }; | |
Channel.prototype.load = function () { | |
var widget = document.createElement("iframe"); | |
widget.{ | |
style.{ | |
width = "100%"; | |
border = "none"; | |
overflow = "hidden"; | |
display = "none"; | |
}; | |
dataset.{ | |
disqusUid = this.uid; | |
}; | |
allowTransparency = true; // < IE8 iframe transparency | |
frameBorder = 0; | |
width = "100%"; | |
id = "dsq" + this.uid; | |
src = this.target + "#" + this.uid; | |
}; | |
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var Channel = function (opts) { /* ... */ }; | |
Channel.prototype.load = function () { | |
var widget = document.createElement("iframe"); | |
widget.{ | |
style.{ | |
width = "100%"; | |
border = "none"; | |
overflow = "hidden"; | |
display = "none"; | |
}; | |
allowTransparency = true; // < IE8 iframe transparency | |
frameBorder = 0; | |
width = "100%"; | |
id = "dsq" + this.uid; | |
data-disqus-uid = this.uid | |
src = this.target + "#" + this.uid; | |
}; | |
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var Channel = function (opts) { /* ... */ }; | |
Channel.prototype.load = function () { | |
var widget = document.createElement('iframe'); | |
widget.setAttribute('style', 'width:100%; border:none; overflow:hidden; display:none'); | |
widget.setAttribute('allowTransparency', 'true'); // < IE8 iframe transparency | |
widget.setAttribute('frameBorder', '0'); | |
widget.setAttribute('width', '100%'); | |
widget.setAttribute('id', 'dsq' + this.uid); | |
widget.setAttribute('data-disqus-uid', this.uid); | |
widget.setAttribute('src', this.target + '#' + this.uid); | |
// ... | |
}; |
@izs: agree on syntax being bad (premature, unjustified, impossible to polyfill, etc.).
@dherman: first, I wonder if we shouldn't just try to standardize Object.extend as the shallow thing, and make it match prototype but handle enumerable accessors too.
Second thought: naming. The set vs. update names do not connote shallow vs. deep. No name that I know of does, so the boring but clear way is Object.deepExtend. Too long? It's not the common case going by existing libraries I know of.
/be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Given the proliferation of subtly different Object.extend implementations, I think this would be a good thing for the ES spec to lay down a decision on. In node, we eventually just removed util.extend entirely, because it was too complicated to satisfy everyone's desires for it to be all things, handling getters and deeply nested objects and so on. New syntax for this is silly, though.
@dherman If I understand you properly, then, Object.update would deep-copy, and Object.set would shallow-copy?
So:
In this example, then,
c.b === a.b
,b.b !== a.b
, andb.b.e
is an evil getter?I have no strong opinions about the method names.
set
andupdate
are fine. But it is a bad idea to introduce new syntax for this, even though it is cute.