Skip to content

Instantly share code, notes, and snippets.

@vddvss
Created February 25, 2020 21:27
Show Gist options
  • Save vddvss/34d0c99adb4bb6bc9653753a8003b560 to your computer and use it in GitHub Desktop.
Save vddvss/34d0c99adb4bb6bc9653753a8003b560 to your computer and use it in GitHub Desktop.
remove-unused-preferences-fields.patch rejects
--- chrome/browser/ui/views/safe_browsing/password_reuse_modal_warning_dialog.cc
+++ chrome/browser/ui/views/safe_browsing/password_reuse_modal_warning_dialog.cc
@@ -142,30 +141,14 @@ PasswordReuseModalWarningDialog::Passwor
ui::DIALOG_BUTTON_CANCEL,
l10n_util::GetStringUTF16(IDS_PAGE_INFO_IGNORE_PASSWORD_WARNING_BUTTON));
- // |service| maybe NULL in tests.
- if (service_)
- service_->AddObserver(this);
-
std::vector<size_t> placeholder_offsets;
- if (password_type.account_type() ==
- ReusedPasswordAccountType::SAVED_PASSWORD) {
- const base::string16 message_body =
- service_->GetWarningDetailText(password_type, &placeholder_offsets);
-
- CreateSavedPasswordReuseModalWarningDialog(
- message_body, service_->GetPlaceholdersForSavedPasswordWarningText(),
- placeholder_offsets);
- } else {
- views::Label* message_body_label = CreateMessageBodyLabel(
- l10n_util::GetStringUTF16(IDS_PAGE_INFO_CHANGE_PASSWORD_DETAILS));
- CreateGaiaPasswordReuseModalWarningDialog(message_body_label);
- }
+ views::Label* message_body_label = CreateMessageBodyLabel(
+ l10n_util::GetStringUTF16(IDS_PAGE_INFO_CHANGE_PASSWORD_DETAILS));
+ CreateGaiaPasswordReuseModalWarningDialog(message_body_label);
}
PasswordReuseModalWarningDialog::~PasswordReuseModalWarningDialog() {
- if (service_)
- service_->RemoveObserver(this);
}
void PasswordReuseModalWarningDialog::
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment