vdeturckheim

DISCLAIMER: This was a working document now availabe in https://github.com/nodejs/TSC/issues/807. No comments on the current gist will be accepted

Executive summary: Introducing a CLS-like API to Node.js core

Context: the 3 PRs and 1 consensus

On the TSC meeting of 2020-JAN-22, the TSC reached consensus regarding the need to have an Asynchronous Storage API in core.

vdeturckheim

Most Node.js framework requires to pass an object representing the current HTTP request through every layers of the application. This is most visible in Expressjs-based applications:

// TODO middleware example

Other frameworks, will create an wrapping object around the raw Node.js request:

// TODO hapi link

But at the end of the day, developers end up passing bloated objects representing the requests through their codebase:

vdeturckheim

MongoDB need to be installed and running on localhost (otherwise, edit the value of MONGO_URL in server.js).

For Sqreen to work, create a new application on https://my.sqreen.io and add the sqreen.json file to the root of the project.

Start the server with node server.js

Perform an attack with:

$ curl -X POST \
  http://localhost:3000/login \

vdeturckheim

Beyond Domains

Goal

The goal of this document is to analysis the content of the Domain Module Postmortem to define the need for either:

• a new internal API in Node.js core (SOLUTION 1)
• a solution to update domain API to have TSC reconsider its deprecation status (SOLUTION 2)
• an external API to replace domain only in userland (SOLUTION 3)

vdeturckheim

Keybase proof

I hereby claim:

• I am vdeturckheim on github.
• I am ecares (https://keybase.io/ecares) on keybase.
• I have a public key ASCYrvfvzp9hRv0VSx6JA_pAUKwnqVsiHgwUuRi-V-HMvQo

To claim this, I am signing this object:

vdeturckheim

'use strict';
const Code = require('code');
const expect = Code.expect;
const Lab = require('lab');
const lab  = module.exports.exports.lab = Lab.script();

const after = lab.after;
const before = lab.before;
const describe = lab.describe;
const it = lab.it;

vdeturckheim

app.post('/posts', Celebrate.celebrate(
    {
        body: Joi.object().keys({
            title: Joi.string().required(),
            content: Joi.string().required()
        })
    }
    ),
    (req, res, next) => {

vdeturckheim

'use strict';
const Express = require('express');
const BP = require('body-parser');

const DB = require('./db.js');

const app = Express();

app.use(BP.json());

vdeturckheim

const DB_NAME = 'tests-express-sqlite';
const Fs = require('fs');
const Path = require('path');
const Sqlite = require('sqlite3');

try {
    Fs.unlinkSync(`./${DB_NAME}`);
}
catch (_ign) {}

vdeturckheim

CREATE TABLE POSTS(
   ID INTEGER PRIMARY KEY   AUTOINCREMENT,
   TITLE           TEXT    NOT NULL,
   CONTENT         TEXT
);

INSERT INTO POSTS (TITLE, CONTENT)
VALUES ('hello world', 'hello');

INSERT INTO POSTS (TITLE, CONTENT)