Skip to content

Instantly share code, notes, and snippets.

@vidhan13j07
Created May 16, 2017 21:59
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save vidhan13j07/223475f516068f829f874fb83ca9d27a to your computer and use it in GitHub Desktop.
Save vidhan13j07/223475f516068f829f874fb83ca9d27a to your computer and use it in GitHub Desktop.
Linting errors remaining in the following files mentioned here: https://github.com/pgRouting/pgrouting/pull/787
src/trsp/src/GraphDefinition.cpp
src/trsp/src/GraphDefinition.cpp:77: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:116: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:120: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:125: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:128: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:152: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:223: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:228: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:255: Using C-style cast. Use reinterpret_cast<path_element_tt *>(...) instead [readability/casting] [4]
src/trsp/src/GraphDefinition.cpp:270: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:273: Using C-style cast. Use const_cast<char *>(...) instead [readability/casting] [4]
src/trsp/src/GraphDefinition.cpp:283: Using C-style cast. Use const_cast<char *>(...) instead [readability/casting] [4]
src/trsp/src/GraphDefinition.cpp:289: Using C-style cast. Use const_cast<char *>(...) instead [readability/casting] [4]
src/trsp/src/GraphDefinition.cpp:320: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:325: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:347: Using C-style cast. Use const_cast<char *>(...) instead [readability/casting] [4]
src/trsp/src/GraphDefinition.cpp:368: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:379: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:453: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:461: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:466: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:508: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:528: Using C-style cast. Use const_cast<char *>(...) instead [readability/casting] [4]
src/trsp/src/GraphDefinition.cpp:534: Using C-style cast. Use const_cast<char *>(...) instead [readability/casting] [4]
src/trsp/src/GraphDefinition.cpp:563: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:568: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:595: Using C-style cast. Use const_cast<char *>(...) instead [readability/casting] [4]
src/trsp/src/GraphDefinition.cpp:619: Using C-style cast. Use reinterpret_cast<path_element_tt *>(...) instead [readability/casting] [4]
src/trsp/src/GraphDefinition.cpp:650: Using C-style cast. Use reinterpret_cast<path_element_tt *>(...) instead [readability/casting] [4]
src/trsp/src/GraphDefinition.cpp:663: Using C-style cast. Use reinterpret_cast<path_element_tt *>(...) instead [readability/casting] [4]
src/trsp/src/GraphDefinition.cpp:764: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:765: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:767: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:778: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:779: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:781: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/GraphDefinition.cpp:794: Add #include <utility> for make_pair [build/include_what_you_use] [4]
src/trsp/src/GraphDefinition.cpp:516: Add #include <queue> for priority_queue<> [build/include_what_you_use] [4]
src/trsp/src/GraphDefinition.cpp:516: Add #include <vector> for vector<> [build/include_what_you_use] [4]
src/trsp/src/GraphDefinition.cpp:28: src/trsp/src/GraphDefinition.cpp should include its header file src/trsp/src/GraphDefinition.h [build/include] [5]
Done processing src/trsp/src/GraphDefinition.cpp
========================================================================================================================================================
src/trsp/src/trsp.c
src/trsp/src/trsp.c:36: Include the directory when naming .h files [build/include] [4]
src/trsp/src/trsp.c:38: Include the directory when naming .h files [build/include] [4]
src/trsp/src/trsp.c:43: Include the directory when naming .h files [build/include] [4]
src/trsp/src/trsp.c:46: Include the directory when naming .h files [build/include] [4]
Done processing src/trsp/src/trsp.c
========================================================================================================================================================
src/trsp/src/trsp_core.cpp
src/trsp/src/trsp_core.cpp:33: Include the directory when naming .h files [build/include] [4]
src/trsp/src/trsp_core.cpp:55: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/trsp_core.cpp:75: Using C-style cast. Use reinterpret_cast<char *>(...) instead [readability/casting] [4]
src/trsp/src/trsp_core.cpp:79: Using C-style cast. Use const_cast<char *>(...) instead [readability/casting] [4]
src/trsp/src/trsp_core.cpp:105: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/trsp_core.cpp:126: Using C-style cast. Use reinterpret_cast<char *>(...) instead [readability/casting] [4]
src/trsp/src/trsp_core.cpp:130: Using C-style cast. Use const_cast<char *>(...) instead [readability/casting] [4]
src/trsp/src/trsp_core.cpp:111: Add #include <utility> for make_pair [build/include_what_you_use] [4]
src/trsp/src/trsp_core.cpp:105: Add #include <vector> for vector<> [build/include_what_you_use] [4]
Done processing src/trsp/src/trsp_core.cpp
========================================================================================================================================================
src/trsp/src/trsp_driver.cpp
src/trsp/src/trsp_driver.cpp:31: Include the directory when naming .h files [build/include] [4]
src/trsp/src/trsp_driver.cpp:108: Add #include <utility> for make_pair [build/include_what_you_use] [4]
src/trsp/src/trsp_driver.cpp:102: Add #include <vector> for vector<> [build/include_what_you_use] [4]
Done processing src/trsp/src/trsp_driver.cpp
========================================================================================================================================================
src/trsp/src/trsp.h
src/trsp/src/trsp.h:27: Include the directory when naming .h files [build/include] [4]
src/trsp/src/trsp.h:32: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/trsp.h:33: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/trsp.h:34: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/trsp.h:47: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/trsp.h:48: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
========================================================================================================================================================
src/trsp/src/utils.h
src/trsp/src/utils.h:34: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/utils.h:86: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/utils.h:86: Is this a non-const reference? If so, make const or use a pointer: std::string& strToken [runtime/references] [2]
src/trsp/src/utils.h:87: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/trsp/src/utils.h:95: Is this a non-const reference? If so, make const or use a pointer: StringVector& vecTokensRef [runtime/references] [2]
Done processing src/trsp/src/utils.h
========================================================================================================================================================
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment