Skip to content

Instantly share code, notes, and snippets.

@vitch
Last active April 19, 2020 20:31
Show Gist options
  • Save vitch/0b5e91d9be89f7eddaef05280068effb to your computer and use it in GitHub Desktop.
Save vitch/0b5e91d9be89f7eddaef05280068effb to your computer and use it in GitHub Desktop.
Splatting input type="range" value
import Component from '@glimmer/component';
export default class extends Component {
}
import Component from '@glimmer/component';
export default class extends Component {
}
import Component from '@ember/component';
export default class extends Component {
isInitialRender = true;
didRender() {
if (!this.isInitialRender) {
return;
}
this.isInitialRender = false;
let inputs = document.getElementsByTagName('input');
let data = [];
for (let input of inputs) {
data.push({
name: input.name,
value: input.value,
valueAttribute: input.getAttribute('value'),
});
};
this.set('data', data);
}
}
import Controller from '@ember/controller';
export default class ApplicationController extends Controller {
appName = 'Ember Twiddle';
}
<input type="range" ...attributes>
<h1>Issue with splatting `value`</h1>
<p>
It looks like passing an unexpected "value" to a range input via splatributes breaks on Ember < 3.17.0
</p>
<p>
The attribute isn't set on the rendered element... Switch the dependency to 3.17.0 to see the expected
behaviour.
</p>
<h2>Normal input</h2>
<input type="range" value="1" name="input-1" />
<input type="range" value="1,10" name="input-1-10" />
<h2>Splatput - splatting all values onto input</h2>
<Splatput type="range" value="1" name="splatput-1" />
<Splatput type="range" value="1,10" name="splatput-1-10" />
<h2>Rangeput - splatting all values except type onto input</h2>
<Rangeput value="1" name="rangeput-1" />
<Rangeput value="1,10" name="rangeput-1-10" />
<dl>
{{#each this.data as |input|}}
<dt>{{input.name}}</dt>
<dd>Value: {{input.value}}</dd>
<dd>Value attribute: {{input.valueAttribute}}</dd>
{{/each}}
</dl>
{
"version": "0.17.0",
"EmberENV": {
"FEATURES": {},
"_TEMPLATE_ONLY_GLIMMER_COMPONENTS": false,
"_APPLICATION_TEMPLATE_WRAPPER": true,
"_JQUERY_INTEGRATION": true
},
"options": {
"use_pods": false,
"enable-testing": false
},
"dependencies": {
"jquery": "https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.js",
"ember": "3.16.3",
"ember-template-compiler": "3.16.3",
"ember-testing": "3.16.3"
},
"addons": {
"@glimmer/component": "1.0.0"
}
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment