Created
January 16, 2017 00:44
-
-
Save vjeux/5b8516202113918de051a0a085ba52e6 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Index: ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/main/Main.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/main/Main.js | |
+++ ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/main/Main.js | |
@@ -82,5 +82,6 @@ | |
*/ | |
function fetchItemFromProvider(provider) { | |
- return /** @type {!WebInspector.StatusBarItem.Provider} */ | |
+ return; | |
+ /** @type {!WebInspector.StatusBarItem.Provider} */ | |
provider.item(); | |
} | |
Index: ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/platform/DOMExtension.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/platform/DOMExtension.js | |
+++ ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/platform/DOMExtension.js | |
@@ -230,6 +230,7 @@ | |
node.nodeType === Node.ELEMENT_NODE && node.classList.contains(className) | |
) | |
- return /** @type {!Element} */ | |
- node; | |
+ return; | |
+ /** @type {!Element} */ | |
+ node; | |
} | |
return null; | |
@@ -242,9 +243,10 @@ | |
var node = this.parentNode; | |
if (!node) return null; | |
- if (node.nodeType === Node.ELEMENT_NODE) return /** @type {!Element} */ | |
- node; | |
- if (node.nodeType === Node.DOCUMENT_FRAGMENT_NODE) | |
- return /** @type {!Element} */ | |
- node.host; | |
+ if (node.nodeType === Node.ELEMENT_NODE) return; | |
+ /** @type {!Element} */ | |
+ node; | |
+ if (node.nodeType === Node.DOCUMENT_FRAGMENT_NODE) return; | |
+ /** @type {!Element} */ | |
+ node.host; | |
return null; | |
}; | |
../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/Runtime.js | |
38 | for (var k of []) | |
39 | | |
40 | | |
41 | /** | |
42 | * @param {string} url | |
43 | * @return {!Promise.<string>} | |
44 | */ | |
45 | function loadResourcePromise(url) { | |
46 | return new Promise(load); | |
47 | | |
48 | /** | |
49 | * @param {function(?)} fulfill | |
50 | * @param {function(*)} reject | |
51 | */ | |
52 | function load(fulfill, reject) { | |
53 | var xhr = new XMLHttpRequest(); | |
{ SyntaxError: Unexpected token (46:0) | |
at Parser.pp$5.raise (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:4333:13) | |
at Parser.pp.unexpected (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:1705:8) | |
at Parser.pp$1.parseStatement (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:1783:30) | |
at Parser.parseStatement (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:5302:22) | |
at Parser.pp$1.parseForIn (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:2270:20) | |
at Parser.pp$1.parseForStatement (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:1972:21) | |
at Parser.pp$1.parseStatement (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:1781:19) | |
at Parser.parseStatement (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:5302:22) | |
at Parser.pp$1.parseBlockBody (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:2212:21) | |
at Parser.pp$1.parseTopLevel (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:1723:8) pos: 1986, loc: Position { line: 46, column: 0 } } | |
Index: ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/sources/SourcesView.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/sources/SourcesView.js | |
+++ ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/sources/SourcesView.js | |
@@ -271,5 +271,6 @@ | |
var view = this.visibleView(); | |
if (!(view instanceof WebInspector.SourceFrame)) return null; | |
- return /** @type {!WebInspector.SourceFrame} */ | |
+ return; | |
+ /** @type {!WebInspector.SourceFrame} */ | |
view; | |
}, | |
Index: ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/sources/TabbedEditorContainer.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/sources/TabbedEditorContainer.js | |
+++ ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/sources/TabbedEditorContainer.js | |
@@ -113,5 +113,6 @@ | |
*/ | |
fileViews: function() { | |
- return /** @type {!Array.<!WebInspector.SourceFrame>} */ | |
+ return; | |
+ /** @type {!Array.<!WebInspector.SourceFrame>} */ | |
this._tabbedPane.tabViews(); | |
}, | |
Index: ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/toolbox/EmulatedDevices.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/toolbox/EmulatedDevices.js | |
+++ ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/toolbox/EmulatedDevices.js | |
@@ -123,5 +123,6 @@ | |
result.width = parseIntValue(json, "width"); | |
result.height = parseIntValue(json, "height"); | |
- return /** @type {!WebInspector.Geometry.Rect} */ | |
+ return; | |
+ /** @type {!WebInspector.Geometry.Rect} */ | |
result; | |
} | |
@@ -136,5 +137,6 @@ | |
result.top = parseIntValue(json, "top"); | |
result.left = parseIntValue(json, "left"); | |
- return /** @type {?WebInspector.Geometry.Insets} */ | |
+ return; | |
+ /** @type {?WebInspector.Geometry.Insets} */ | |
result; | |
} | |
@@ -196,5 +198,6 @@ | |
} | |
- return /** @type {!WebInspector.EmulatedDevice.Orientation} */ | |
+ return; | |
+ /** @type {!WebInspector.EmulatedDevice.Orientation} */ | |
result; | |
} | |
Index: ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/ui/ActionRegistry.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/ui/ActionRegistry.js | |
+++ ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/ui/ActionRegistry.js | |
@@ -67,5 +67,6 @@ | |
*/ | |
function handleAction(actionDelegate) { | |
- return /** @type {!WebInspector.ActionDelegate} */ | |
+ return; | |
+ /** @type {!WebInspector.ActionDelegate} */ | |
actionDelegate.handleAction(WebInspector.context); | |
} | |
Index: ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/ui/ColorSwatch.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/ui/ColorSwatch.js | |
+++ ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/ui/ColorSwatch.js | |
@@ -20,5 +20,6 @@ | |
); | |
- return /** @type {!WebInspector.ColorSwatch} */ | |
+ return; | |
+ /** @type {!WebInspector.ColorSwatch} */ | |
new WebInspector.ColorSwatch._constructor(); | |
}; | |
Index: ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/ui/HistoryInput.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/ui/HistoryInput.js | |
+++ ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/ui/HistoryInput.js | |
@@ -20,5 +20,6 @@ | |
); | |
- return /** @type {!WebInspector.HistoryInput} */ | |
+ return; | |
+ /** @type {!WebInspector.HistoryInput} */ | |
new WebInspector.HistoryInput._constructor(); | |
}; | |
Index: ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/ui/Panel.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/ui/Panel.js | |
+++ ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/ui/Panel.js | |
@@ -229,5 +229,6 @@ | |
*/ | |
function createPanel(panelFactory) { | |
- return /** @type {!WebInspector.PanelFactory} */ | |
+ return; | |
+ /** @type {!WebInspector.PanelFactory} */ | |
panelFactory.createPanel(); | |
} | |
Index: ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/ui_lazy/DataGrid.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/ui_lazy/DataGrid.js | |
+++ ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/ui_lazy/DataGrid.js | |
@@ -1151,5 +1151,6 @@ | |
this.createCells(); | |
} | |
- return /** @type {!Element} */ | |
+ return; | |
+ /** @type {!Element} */ | |
this._element; | |
}, | |
Index: ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/ui_lazy/ViewportDataGrid.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/ui_lazy/ViewportDataGrid.js | |
+++ ../nuclide/pkg/nuclide-debugger/VendorLib/devtools/front_end/ui_lazy/ViewportDataGrid.js | |
@@ -306,5 +306,6 @@ | |
} | |
- return /** @type {!Element} */ | |
+ return; | |
+ /** @type {!Element} */ | |
this._element; | |
}, | |
../nuclide/pkg/nuclide-debugger-node-rpc/VendorLib/node_modules/async/lib/async.js | |
1186 | } | |
1187 | // AMD / RequireJS else if (typeof define !== "undefined" && define.amd) { | |
1188 | define([], function() { | |
1189 | return async; | |
1190 | }); | |
1191 | } | |
1192 | // included directly via <script> tag else { | |
1193 | root.async = async; | |
1194 | } | |
1195 | })(); | |
1196 | | |
{ SyntaxError: Unexpected token, expected , (1194:4) | |
at Parser.pp$5.raise (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:4333:13) | |
at Parser.pp.unexpected (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:1705:8) | |
at Parser.pp.expect (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:1693:33) | |
at Parser.pp$3.parseParenAndDistinguishExpression (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:3731:12) | |
at Parser.pp$3.parseExprAtom (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:3629:19) | |
at Parser.parseExprAtom (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:6591:22) | |
at Parser.pp$3.parseExprSubscripts (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:3414:19) | |
at Parser.pp$3.parseMaybeUnary (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:3394:19) | |
at Parser.pp$3.parseExprOps (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:3324:19) | |
at Parser.pp$3.parseMaybeConditional (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:3301:19) | |
at Parser.pp$3.parseMaybeAssign (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:3264:19) pos: 29535, loc: Position { line: 1194, column: 4 } } | |
../nuclide/pkg/nuclide-debugger-node-rpc/VendorLib/node_modules/v8-debug/tools/NODE_NEXT.js | |
{ SyntaxError: 'return' outside of function (1:0) | |
at Parser.pp$5.raise (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:4333:13) | |
at Parser.pp$1.parseReturnStatement (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:2012:10) | |
at Parser.pp$1.parseStatement (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:1794:19) | |
at Parser.parseStatement (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:5302:22) | |
at Parser.pp$1.parseBlockBody (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:2212:21) | |
at Parser.pp$1.parseTopLevel (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:1723:8) | |
at Parser.parse (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:1617:17) | |
at Object.parse (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:6657:37) | |
at format (/Users/vjeux/random/prettier/index.js:41:19) | |
at formatWithShebang (/Users/vjeux/random/prettier/index.js:58:12) | |
at Object.format (/Users/vjeux/random/prettier/index.js:69:12) pos: 0, loc: Position { line: 1, column: 0 } } | |
Index: ../nuclide/pkg/nuclide-debugger-node-rpc/VendorLib/node_modules/v8-debug/InjectedScript/InjectedScriptSource.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-debugger-node-rpc/VendorLib/node_modules/v8-debug/InjectedScript/InjectedScriptSource.js | |
+++ ../nuclide/pkg/nuclide-debugger-node-rpc/VendorLib/node_modules/v8-debug/InjectedScript/InjectedScriptSource.js | |
@@ -234,5 +234,6 @@ | |
var isInstance = InjectedScriptHost.suppressWarningsAndCallFunction( | |
function(object, interfaceName) { | |
- return /* suppressBlacklist */ | |
+ return; | |
+ /* suppressBlacklist */ | |
typeof inspectedGlobalObject[interfaceName] === "function" && | |
object instanceof inspectedGlobalObject[interfaceName]; | |
@@ -302,5 +303,6 @@ | |
if (this.isPrimitiveValue(object)) result.value = object; | |
else result.description = toString(object); | |
- return /** @type {!RuntimeAgent.RemoteObject} */ | |
+ return; | |
+ /** @type {!RuntimeAgent.RemoteObject} */ | |
result; | |
}, | |
@@ -1291,5 +1293,6 @@ | |
if (isSymbol(obj)) { | |
try { | |
- return /** @type {string} */ | |
+ return; | |
+ /** @type {string} */ | |
InjectedScriptHost.callFunction(Symbol.prototype.toString, obj) || | |
"Symbol"; | |
Index: ../nuclide/pkg/nuclide-debugger-php-rpc/lib/ConnectionMultiplexer.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-debugger-php-rpc/lib/ConnectionMultiplexer.js | |
+++ ../nuclide/pkg/nuclide-debugger-php-rpc/lib/ConnectionMultiplexer.js | |
@@ -395,13 +395,18 @@ | |
connection.getStatus() === ConnectionStatus.Break && | |
(connection.getStopReason() !== ASYNC_BREAK || | |
- this._status === | |
- ConnectionMultiplexerStatus.UserAsyncBreakSent) && (!getSettings().singleThreadStepping || this._lastEnabledConnection === null || connection === this._lastEnabledConnection) && (!connection.isDummyConnection() || connection.isViewable()); | |
+ this._status === ConnectionMultiplexerStatus.UserAsyncBreakSent) && | |
+ (!getSettings().singleThreadStepping || | |
+ this._lastEnabledConnection === null || | |
+ connection === this._lastEnabledConnection) && | |
+ (!connection.isDummyConnection() || connection.isViewable()); | |
} | |
_isFirstStartingConnection(connection: Connection): boolean { | |
- return // Dummy connection + first connection. | |
+ return; | |
+ // Dummy connection + first connection. | |
this._status === ConnectionMultiplexerStatus.UserAsyncBreakSent && | |
connection.getStatus() === ConnectionStatus.Starting && | |
- this._connections.size === 2 && !connection.isDummyConnection(); | |
+ this._connections.size === 2 && | |
+ !connection.isDummyConnection(); | |
} | |
Index: ../nuclide/pkg/nuclide-debugger-php-rpc/lib/helpers.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-debugger-php-rpc/lib/helpers.js | |
+++ ../nuclide/pkg/nuclide-debugger-php-rpc/lib/helpers.js | |
@@ -43,7 +43,8 @@ | |
const processes = await checkOutput("ps", [ "aux" ], {}); | |
return processes.stdout.toString().split("\n").slice(1).some(line => { | |
- return // hhvm -m debug | |
- line.indexOf("m debug") >= | |
- 0 || line.indexOf("mode debug") >= 0; // hhvm --mode debug | |
+ return; | |
+ // hhvm -m debug | |
+ line.indexOf("m debug") >= 0 || | |
+ line.indexOf("mode debug") >= 0; // hhvm --mode debug | |
}); | |
} | |
Index: ../nuclide/pkg/nuclide-diagnostics-ui/lib/DiagnosticsPanel.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-diagnostics-ui/lib/DiagnosticsPanel.js | |
+++ ../nuclide/pkg/nuclide-diagnostics-ui/lib/DiagnosticsPanel.js | |
@@ -89,5 +89,5 @@ | |
href="http://nuclide.io/docs/advanced-topics/linter-package-compatibility/" | |
> | |
- Learn More | |
+ Learn More | |
</a>. | |
</span> | |
Index: ../nuclide/pkg/nuclide-file-tree/lib/FileSystemActions.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-file-tree/lib/FileSystemActions.js | |
+++ ../nuclide/pkg/nuclide-file-tree/lib/FileSystemActions.js | |
@@ -325,5 +325,5 @@ | |
message: ( | |
<span> | |
- Enter the path for the new {entryType} in the root:<br />{path} | |
+ Enter the path for the new {entryType} in the root:<br />{path} | |
</span> | |
), | |
Index: ../nuclide/pkg/nuclide-grep-rpc/lib/scanhandler.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-grep-rpc/lib/scanhandler.js | |
+++ ../nuclide/pkg/nuclide-grep-rpc/lib/scanhandler.js | |
@@ -154,5 +154,6 @@ | |
).share(); | |
- return // Limit the total result size. | |
+ return; | |
+ // Limit the total result size. | |
results | |
.merge( | |
Index: ../nuclide/pkg/nuclide-hack-rpc/lib/Completions.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-hack-rpc/lib/Completions.js | |
+++ ../nuclide/pkg/nuclide-hack-rpc/lib/Completions.js | |
@@ -34,5 +34,6 @@ | |
const hackCompletionsComparator = compareHackCompletions(prefix); | |
- return // The returned completions may have unrelated results, even though the offset | |
+ return; | |
+ // The returned completions may have unrelated results, even though the offset | |
// is set on the end of the prefix. | |
processCompletions(hackCompletions, contents, offset, prefix) | |
Index: ../nuclide/pkg/nuclide-health/lib/ui/sections/HandlesTableComponent.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-health/lib/ui/sections/HandlesTableComponent.js | |
+++ ../nuclide/pkg/nuclide-health/lib/ui/sections/HandlesTableComponent.js | |
@@ -57,11 +57,9 @@ | |
<tr> | |
<th width="10%">ID</th> | |
- { | |
- this.props.columns.map((column, c) => ( | |
+ {this.props.columns.map((column, c) => ( | |
<th key={c} width={`${column.widthPercentage}%`}> | |
{column.title} | |
</th> | |
- )) | |
- } | |
+ ))} | |
</tr> | |
</thead> | |
Index: ../nuclide/pkg/nuclide-home/lib/HomePaneItem.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-home/lib/HomePaneItem.js | |
+++ ../nuclide/pkg/nuclide-home/lib/HomePaneItem.js | |
@@ -137,10 +137,9 @@ | |
} | |
- return // Re-use styles from the Atom welcome pane where possible. | |
- ( | |
- <div className="nuclide-home pane-item padded nuclide-home-containers"> | |
- {containers} | |
- </div> | |
- ); | |
+ return; | |
+ // Re-use styles from the Atom welcome pane where possible. | |
+ <div className="nuclide-home pane-item padded nuclide-home-containers"> | |
+ {containers} | |
+ </div>; | |
} | |
Index: ../nuclide/pkg/nuclide-outline-view/lib/OutlineView.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-outline-view/lib/OutlineView.js | |
+++ ../nuclide/pkg/nuclide-outline-view/lib/OutlineView.js | |
@@ -203,10 +203,9 @@ | |
return null; | |
} | |
- return // Add `position: relative;` to let `li.selected` style position itself relative to the list | |
+ return; | |
+ // Add `position: relative;` to let `li.selected` style position itself relative to the list | |
// tree rather than to its container. | |
- ( | |
- <ul className="list-tree" style={{ position: "relative" }}> | |
- {outlines.map((outline, index) => renderTree(editor, outline, index))} | |
- </ul> | |
- ); | |
+ <ul className="list-tree" style={{ position: "relative" }}> | |
+ {outlines.map((outline, index) => renderTree(editor, outline, index))} | |
+ </ul>; | |
} | |
Index: ../nuclide/pkg/nuclide-refactorizer/lib/refactorEpics.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-refactorizer/lib/refactorEpics.js | |
+++ ../nuclide/pkg/nuclide-refactorizer/lib/refactorEpics.js | |
@@ -52,5 +52,6 @@ | |
actions: ActionsObservable<RefactorAction> | |
): Observable<RefactorAction> { | |
- return // This is weird but Flow won't accept `action.error` or even `Boolean(action.error)` | |
+ return; | |
+ // This is weird but Flow won't accept `action.error` or even `Boolean(action.error)` | |
actions | |
.filter(action => action.error ? true : false) | |
Index: ../nuclide/pkg/nuclide-refactorizer/spec/refactorStore-spec.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-refactorizer/spec/refactorStore-spec.js | |
+++ ../nuclide/pkg/nuclide-refactorizer/spec/refactorStore-spec.js | |
@@ -91,7 +91,5 @@ | |
const stream: Observable<RefactorState> = Observable.from(store); | |
stateStream = // Filter out duplicate states. This happens during error handling, for example. | |
- stream | |
- .distinctUntilChanged() | |
- .publishReplay(); | |
+ stream.distinctUntilChanged().publishReplay(); | |
stateStream.connect(); | |
// stateStream will replay, but it's also useful to be able to wait for particular states before | |
Index: ../nuclide/pkg/nuclide-remote-connection/lib/SshHandshake.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-remote-connection/lib/SshHandshake.js | |
+++ ../nuclide/pkg/nuclide-remote-connection/lib/SshHandshake.js | |
@@ -253,11 +253,11 @@ | |
} | |
- const connection = (await RemoteConnection.createConnectionBySavedConfig( | |
+ const connection = // We save connections by their IP address as well, in case a different hostname | |
+ // was used for the same server. | |
+ (await RemoteConnection.createConnectionBySavedConfig( | |
this._config.host, | |
this._config.cwd, | |
this._config.displayTitle | |
)) || | |
- // We save connections by their IP address as well, in case a different hostname | |
- // was used for the same server. | |
(await RemoteConnection.createConnectionBySavedConfig( | |
address, | |
Index: ../nuclide/pkg/nuclide-remote-projects/lib/ConnectionDialog.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-remote-projects/lib/ConnectionDialog.js | |
+++ ../nuclide/pkg/nuclide-remote-projects/lib/ConnectionDialog.js | |
@@ -160,6 +160,9 @@ | |
// The next profiles list is longer than before, a new one was added | |
// The current selection is outside the bounds of the next profiles list | |
- this.props.connectionProfiles == | |
- null || indexOfSelectedConnectionProfile > nextProps.connectionProfiles.length - 1 || nextProps.connectionProfiles.length > this.props.connectionProfiles.length | |
+ this.props.connectionProfiles == null || | |
+ indexOfSelectedConnectionProfile > | |
+ nextProps.connectionProfiles.length - 1 || | |
+ nextProps.connectionProfiles.length > | |
+ this.props.connectionProfiles.length | |
) { | |
// Select the final connection profile in the list because one of the above conditions means | |
Index: ../nuclide/pkg/nuclide-react-inspector/VendorLib/dev-tools/build/standalone.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-react-inspector/VendorLib/dev-tools/build/standalone.js | |
+++ ../nuclide/pkg/nuclide-react-inspector/VendorLib/dev-tools/build/standalone.js | |
@@ -10542,5 +10542,6 @@ | |
var nextEmpty = nextElement === null || nextElement === false; | |
- return // This has a few false positives w/r/t empty components. | |
+ return; | |
+ // This has a few false positives w/r/t empty components. | |
prevEmpty || nextEmpty || nextElement.ref !== prevElement.ref || | |
// If owner changes but we have an unchanged function ref, don't update refs | |
@@ -11143,7 +11144,11 @@ | |
var reIsNative = RegExp( | |
"^" + // Take an example native function source for comparison | |
- funcToString.call( | |
- hasOwnProperty | |
- ).replace(/[\\^$.*+?()[\]{}|]/g, "\\$&").replace(/hasOwnProperty|(function).*?(?=\\\()| for .+?(?=\\\])/g, "$1.*?") + "$" | |
+ funcToString | |
+ .call(hasOwnProperty) | |
+ .replace(/[\\^$.*+?()[\]{}|]/g, "\\$&") | |
+ .replace( | |
+ /hasOwnProperty|(function).*?(?=\\\()| for .+?(?=\\\])/g, | |
+ "$1.*?" | |
+ ) + "$" | |
); | |
try { | |
@@ -13715,7 +13720,9 @@ | |
*/ | |
function hasArrayNature(obj) { | |
- return // not null/false | |
- !!obj && // arrays are objects, NodeLists are functions in Safari | |
- (typeof obj == "object" || | |
+ return; | |
+ // not null/false | |
+ // a real array | |
+ // arrays are objects, NodeLists are functions in Safari | |
+ !!obj && (typeof obj == "object" || | |
typeof obj == "function") && // quacks like an array | |
"length" in obj && // not window | |
@@ -13723,6 +13730,5 @@ | |
obj) && // no DOM node should be considered an array-like | |
// a 'select' element has 'length' and 'item' properties on IE8 | |
- typeof obj.nodeType != "number" && // a real array | |
- (Array.isArray(obj) || // arguments | |
+ typeof obj.nodeType != "number" && (Array.isArray(obj) || // arguments | |
"callee" in obj || // HTMLCollection/NodeList | |
"item" in obj); | |
../nuclide/pkg/nuclide-server/lib/main.js | |
86 | | |
87 | const argv = yargs.default("port", DEFAULT_PORT).argv; | |
88 | | |
89 | main(argv); | |
90 | | |
91 | // Make it clear that this is not a types module by adding an empty export. | |
92 | export | |
93 | | |
{ SyntaxError: Unexpected token, expected { (94:0) | |
at Parser.pp$5.raise (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:4333:13) | |
at Parser.pp.unexpected (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:1705:8) | |
at Parser.pp.expect (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:1693:33) | |
at Parser.pp$1.parseExportSpecifiers (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:2756:8) | |
at Parser.pp$1.parseExport (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:2584:28) | |
at Parser.parseExport (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:5380:20) | |
at Parser.pp$1.parseStatement (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:1830:74) | |
at Parser.parseStatement (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:5302:22) | |
at Parser.pp$1.parseBlockBody (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:2212:21) | |
at Parser.pp$1.parseTopLevel (/Users/vjeux/random/prettier/node_modules/babylon/lib/index.js:1723:8) pos: 2802, loc: Position { line: 94, column: 0 } } | |
Index: ../nuclide/pkg/nuclide-settings/lib/SettingsCategory.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-settings/lib/SettingsCategory.js | |
+++ ../nuclide/pkg/nuclide-settings/lib/SettingsCategory.js | |
@@ -52,5 +52,5 @@ | |
{} | |
<h1 className="block section-heading icon icon-gear"> | |
- {this.props.name} Settings | |
+ {this.props.name}Settings | |
</h1> | |
{children} | |
Index: ../nuclide/pkg/nuclide-task-runner/lib/redux/Epics.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-task-runner/lib/redux/Epics.js | |
+++ ../nuclide/pkg/nuclide-task-runner/lib/redux/Epics.js | |
@@ -93,18 +93,18 @@ | |
} | |
return taskRunner.observeTaskList(cb); | |
- }) | |
- .takeUntil(diffs.filter(diff => diff.removed.has(taskRunnerId))) | |
- .map(taskList => { | |
- // Annotate each task with some info about its runner. | |
- const annotatedTaskList = taskList.map(task => ({ | |
- ...task, | |
- taskRunnerId, | |
- taskRunnerName: taskRunner.name | |
- })); | |
- // Tag each task list with the id of its runner for adding to the map. | |
- return { taskRunnerId, taskList: annotatedTaskList }; | |
- }) | |
- .concat(Observable.of({ taskRunnerId, taskList: null })) | |
- .publish(); | |
+ }).takeUntil( | |
+ diffs.filter(diff => diff.removed.has(taskRunnerId)) | |
+ ).map(taskList => { | |
+ // Annotate each task with some info about its runner. | |
+ const annotatedTaskList = taskList.map(task => ({ | |
+ ...task, | |
+ taskRunnerId, | |
+ taskRunnerName: taskRunner.name | |
+ })); | |
+ // Tag each task list with the id of its runner for adding to the map. | |
+ return { taskRunnerId, taskList: annotatedTaskList }; | |
+ }).concat( | |
+ Observable.of({ taskRunnerId, taskList: null }) | |
+ ).publish(); | |
// Use `Observable.create()` to make sure we only have one subscription to taskLists and | |
@@ -244,5 +244,6 @@ | |
} | |
- return // Stop listening once the task is done. | |
+ return; | |
+ // Stop listening once the task is done. | |
createTaskObservable( | |
activeTaskRunner, | |
Index: ../nuclide/pkg/nuclide-task-runner/lib/ui/Toolbar.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-task-runner/lib/ui/Toolbar.js | |
+++ ../nuclide/pkg/nuclide-task-runner/lib/ui/Toolbar.js | |
@@ -114,14 +114,10 @@ | |
function Placeholder(): React.Element<any> { | |
- return // Themes actually change the size of UI elements (sometimes even dynamically!) and can | |
+ return; | |
+ // Themes actually change the size of UI elements (sometimes even dynamically!) and can | |
// therefore change the size of the toolbar! To try to ensure that the placholder has the same | |
// height as the toolbar, we put a dummy button in it and hide it with CSS. | |
- ( | |
- <Button | |
- className="nuclide-task-runner-placeholder" | |
- size={ButtonSizes.SMALL} | |
- > | |
- Seeing this button is a bug! | |
- </Button> | |
- ); | |
+ <Button className="nuclide-task-runner-placeholder" size={ButtonSizes.SMALL}> | |
+ Seeing this button is a bug! | |
+ </Button>; | |
} | |
Index: ../nuclide/pkg/nuclide-test-runner/lib/ui/TestRunnerPanel.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-test-runner/lib/ui/TestRunnerPanel.js | |
+++ ../nuclide/pkg/nuclide-test-runner/lib/ui/TestRunnerPanel.js | |
@@ -162,5 +162,5 @@ | |
runMsg = ( | |
<span className="inline-block"> | |
- Done (in {this.props.runDuration / 1000}s) | |
+ Done (in {this.props.runDuration / 1000}s) | |
</span> | |
); | |
Index: ../nuclide/pkg/nuclide-ui/AtomInput.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-ui/AtomInput.js | |
+++ ../nuclide/pkg/nuclide-ui/AtomInput.js | |
@@ -191,17 +191,16 @@ | |
}); | |
- return // Because the contents of `<atom-text-editor>` elements are managed by its custom web | |
+ return; | |
+ // Because the contents of `<atom-text-editor>` elements are managed by its custom web | |
// component class when "Use Shadow DOM" is disabled, this element should never have children. | |
// If an element has no children, React guarantees it will never re-render the element (which | |
// would wipe out the web component's work in this case). | |
- ( | |
- <atom-text-editor | |
- class={className} | |
- mini | |
- onClick={this.props.onClick} | |
- onFocus={this.props.onFocus} | |
- onBlur={this.props.onBlur} | |
- /> | |
- ); | |
+ <atom-text-editor | |
+ class={className} | |
+ mini | |
+ onClick={this.props.onClick} | |
+ onFocus={this.props.onFocus} | |
+ onBlur={this.props.onBlur} | |
+ />; | |
} | |
Index: ../nuclide/pkg/nuclide-ui/Dropdown.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-ui/Dropdown.js | |
+++ ../nuclide/pkg/nuclide-ui/Dropdown.js | |
@@ -217,7 +217,5 @@ | |
}); | |
- const label = props.children == null | |
- ? null | |
- : ( | |
+ const label = props.children == null ? null : ( | |
<span className="nuclide-dropdown-label-text-wrapper"> | |
{props.children} | |
Index: ../nuclide/pkg/nuclide-ui/RelativeDate.example.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-ui/RelativeDate.example.js | |
+++ ../nuclide/pkg/nuclide-ui/RelativeDate.example.js | |
@@ -17,8 +17,10 @@ | |
<Block> | |
<div> | |
- Updated every 10 seconds (default): "<RelativeDate date={new Date()} />" | |
+ Updated every 10 seconds (default): "<RelativeDate | |
+ date={new Date()} | |
+ />" | |
</div> | |
<div> | |
- Updated every 1 second: "<RelativeDate | |
+ Updated every 1 second: "<RelativeDate | |
date={new Date()} | |
delay={1000} | |
Index: ../nuclide/pkg/nuclide-vcs-log/lib/VcsLog.js | |
=================================================================== | |
--- ../nuclide/pkg/nuclide-vcs-log/lib/VcsLog.js | |
+++ ../nuclide/pkg/nuclide-vcs-log/lib/VcsLog.js | |
@@ -117,13 +117,9 @@ | |
<th className="nuclide-vcs-log-header-cell">Date</th> | |
<th className="nuclide-vcs-log-header-cell">ID</th> | |
- { | |
- showDifferentialRevision | |
- ? ( | |
+ {showDifferentialRevision ? ( | |
<th className="nuclide-vcs-log-header-cell"> | |
Revision | |
</th> | |
- ) | |
- : null | |
- } | |
+ ) : null} | |
<th className="nuclide-vcs-log-header-cell">Author</th> | |
<th className="nuclide-vcs-log-header-cell">Summary</th> | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment