Skip to content

Instantly share code, notes, and snippets.

@weiser

weiser/coc_pr_proposal.md

Last active March 30, 2016 23:22
Show Gist options
  • Save weiser/83aacc3a81f90c8144bb to your computer and use it in GitHub Desktop.
Save weiser/83aacc3a81f90c8144bb to your computer and use it in GitHub Desktop.
Download ZIP
Raw
coc_pr_proposal.md

A proposed code of conduct for code reviews. I think it would help us maintain our team culture when our team grows so that new team members know what we expect and it can also serve as a reminder to us how we want to operate.

  1. Show appreciation that someone took time/energy to do submit the CR.
  2. Keep criticism constructive.
  3. No ad hominems.
  4. When you disagree, view it as a teaching moment. Seek to understand rather than only prove yourself right. You might be wrong.
  5. View constructive criticism as a benefit. You get to level up your skills!
@tony-bye
Copy link

I'd like to see something about what the expectations are for
1 time frame, or how quickly a PR should be looked at.
2 how comments/suggestions should be treated. I think any suggestion should get a response before a PR is closed, so that at least the commenter knows it was seen. I don't think every suggestion actually needs to be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment