Skip to content

Instantly share code, notes, and snippets.

@whitmo

whitmo/terraform-review.md

Created December 4, 2018 14:43
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save whitmo/39305695725176b51233991067f9b758 to your computer and use it in GitHub Desktop.
Save whitmo/39305695725176b51233991067f9b758 to your computer and use it in GitHub Desktop.
Download ZIP
Reviewing terraform
Raw
terraform-review.md

Code review for terraform

https://github.com/18F/development-guide/tree/master/code_review

PR review

  1. Does it make sense? Can I reason about it? Can I follow and understand
  2. Does it increase or decrease complexity? Is it simple as possible?
  3. Has it been fmted
  4. Is the scope correct for problem?
  5. Decisions are commented (the why, and sideeffects for other systems)
  6. WIP code flagged?
  7. Visually tested (like a plan)?
  8. Is there documentation?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment