DH testing notes

test_classifier.md

• why nest another package.json / node_modules dir in test?

  • should use devDependencies and NODE_ENV=production to avoid loading tests

• test/test/mocha.opts could probably just be in test/mocha.opts

• forking the server and forwarding args might not be needed

  • as does the need for a Q deferred
  • exporting the server and starting / stopping in the same proc as part of the test run should be fine

• before / after can both take done args, be async

  • as called out by the comment in test_classifier, there's some really nasty stuff going on because of this
  • mocha has a context that's held between test blocks
  • using mocha for flow control is wrong... async.waterfall could handle most of the craziness in test_classifier

• prettyVerifyAttributes should just be in its own module

• prepareHttpRequest can be replaced by mikeal/request + Q in literally 3 lines

• remove dead code. if you really need it, leave a comment with the sha that it was removed in, or link back to GH

• does presence of an SSL drastically effect test runs? why would tests ever care about an upstream impl detail like that?

• tests have more leeway here, but unleashing zalgo makes most of this more painful to sift through than it could be