wrowe

Replace PCRE with PCRE2 where it is available. PCRE 8.45 from May '21 is at
end-of-life and will not receive security vulnerability attention. pcre2-10.x 
replaces this and has been updated (as of this time) as recently as Oct '21.

This patch removes the needless assignment of re_erroffset in the conf pool
by the worker threads; such mistakes break the shared copy-on-write pages of
memory that should have remained common between all httpd worker processes.

Two de-optimizations are inherent in this patch, the former ovector-on-stack
opportunity is lost. This is by design of pcre2, more serious exploits were 

wrowe

2021-01-14T23:13:10.7742566Z ==================== Test output for //test/extensions/filters/network/sni_dynamic_forward_proxy:proxy_filter_integration_test:
2021-01-14T23:13:10.7749950Z [ RUN      ] IpVersions/SniDynamicProxyFilterIntegrationTest.UpstreamTls/IPv4
2021-01-14T23:13:10.7842601Z TestRandomGenerator running with seed -1650745244
2021-01-14T23:13:10.7843141Z TestRandomGenerator running with seed -1650745244
2021-01-14T23:13:10.7843667Z TestRandomGenerator running with seed -1650745244
2021-01-14T23:13:10.7845388Z TestRandomGenerator running with seed -1650745244
2021-01-14T23:13:10.7845823Z TestRandomGenerator running with seed -1650745244
2021-01-14T23:13:10.7846207Z TestRandomGenerator running with seed -1650745244
2021-01-14T23:13:10.7846540Z TestRandomGenerator running with seed -1650745244
2021-01-14T23:13:10.7846990Z test/integration/http_integration.cc(239): error: Value of: codec->connected()

wrowe

2021-01-14T05:00:39.7281323Z ==================== Test output for //test/extensions/filters/http/dynamic_forward_proxy:proxy_filter_integration_test:
2021-01-14T05:00:39.7283542Z [ RUN      ] IpVersions/ProxyFilterIntegrationTest.RequestWithBody/IPv4
2021-01-14T05:00:39.7284057Z TestRandomGenerator running with seed 617636800
2021-01-14T05:00:39.7284618Z TestRandomGenerator running with seed 617636800
2021-01-14T05:00:39.7285026Z TestRandomGenerator running with seed 617636800
2021-01-14T05:00:39.7285716Z TestRandomGenerator running with seed 617636800
2021-01-14T05:00:39.7286236Z TestRandomGenerator running with seed 617636800
2021-01-14T05:00:39.7286656Z TestRandomGenerator running with seed 617636800
2021-01-14T05:00:39.7287124Z TestRandomGenerator running with seed 617636800
2021-01-14T05:00:39.7287758Z [2021-01-14 04:59:58.702][4496][critical][assert] [test/integration/http_integration.cc:388] assert failure: 0. Details: Timed out waiting for new connection.

wrowe

Executing tests from //test/common/network:dns_impl_test
-----------------------------------------------------------------------------
[2021-01-14 17:51:48.513][8740][info][testing] [test/test_runner.cc:121] Running with runtime feature override disable envoy.restart_features.use_apple_api_for_dns_lookups

[==========] Running 41 tests from 6 test suites.
[----------] Global test environment set-up.
[----------] 3 tests from DnsImplConstructor
[ RUN      ] DnsImplConstructor.SupportsCustomResolvers
[       OK ] DnsImplConstructor.SupportsCustomResolvers (129 ms)
[ RUN      ] DnsImplConstructor.SupportCustomAddressInstances

wrowe

#include <windows.h>
#include <stdio.h>

int main(int argc, char** argv) {

  WIN32_FIND_DATA find_data;
  HANDLE dh;
  dh = FindFirstFile(argv[1], &find_data);
  if (dh == INVALID_HANDLE_VALUE) {
    printf("File open %s failed with error %d\n\n", argv[1], GetLastError());

wrowe

Building STATIC /MT LIBCMT[d];

Dump of file .\bazel-out\x64_windows-dbg\bin\source\exe\envoy-static.exe

File Type: EXECUTABLE IMAGE

  Image has the following dependencies:

    ADVAPI32.dll
    WS2_32.dll