Hello Github,
Pull requests are not serving me well on large reviews. Here are some problems and suggested enhancements that would make me happy.
- Mark comment as "resolved" (see google docs for an example). As code changes, comments get lost or made redundant, and it is not clear (to either the author or reviewers) which are still relevant and which have been addressed. Resolving a comment doesn't need to make it dissappear, but I need to be able to see "which comments have not been addressed" somehow. This feature would be the most useful to me.
- Reply to a comment. This can be done in effect on line comments (assuming there is only one), but cannot on PR comments. Particularly with many threads, the lack of this makes a review hard to follow.
- Explicit "approve/block" life cycle. The block is actually more important to me ... often on a PR that has been incrementally improved I want to "block" final merge of it until I get a chance to rebase/squash and generally pretty it up. The block can be overridable, I just want a warning when you try to merge that "this will make XXX really sad". I had a heap of disgusting WIP commits merged to repo the other day by someone else that I will forever be embarrased by.
- Incremental diffs. What changed since the last time I reviewed this? A quick way to change the base of the "files changed" diff would be great. Bonus points if I can force push my branch and you track the different shas and I can compare them. I do double-PRs to work around this which is not really cool.
Example large pull requests:
I'm happy to provide more detail or talk with someone on the phone if it would assist.
Thanks, Xavier
+1 for resolving comments manually