Skip to content

Instantly share code, notes, and snippets.

@xknat

xknat/txt.md

Last active March 16, 2021 21:42
Show Gist options
  • Save xknat/d079f0d18520f229761168d5526fab51 to your computer and use it in GitHub Desktop.
Save xknat/d079f0d18520f229761168d5526fab51 to your computer and use it in GitHub Desktop.
Download ZIP
SR v14 update
Raw
txt.md

= MAJOR CHANGES =

  • The BIG tweaks / cleanup after undusting some old code & comments (some not used any more)

    • Removing copy'd project's and use them as project imports (XMaterial, duckbypass & more).
    • Merging Strings
    • Adding final's where posible.
    • Switching operators to cancel faster
    • Un "this" code for smaller and easier to read code.

  • SkinsGUI is now using same "/skin set " code to apply skin

    • Check cooldown on run (Since we reuse skin set code, it now also has cooldown.)
    • Respect disabled skins

  • Skins with expire 0 will never update

  • Added "/sr applyskin ", [PERM: skinsrestorer.admincommand.applyskin] (This way you can apply a skin after disableonjoinskin to allow texturepack popup)

  • Added "/sr createcustom ", [PERM: skinsrestorer.admincommand.createcustom] (This should allow mods to edit / create custom skins.)

  • We cut jar size by more then half

  • We now encrypt the seed so we don't "leak" it. (even though you can reverse engineer any world by now)

  • A way to disable auto updates

  • RestrictSkinUrls (formely AllowedUrls) is now (default disabled) list in which you can allowlist skinurl domains.

  • https://github.com/slamdunx fix for saving usernames skins with special charachter ("*")

  • https://github.com/1MagicSweet for fixing velocity again

= Improvements =

  • New "DANGER ZONE" config section
  • Admin's can now set the skin of users with illegal names (floodgate).
  • We now give a warning about Illegal reflective access (if you use java9+)
  • Grammer mistakes were made, and fixed, for now, i hope :P.
  • Removed name validation at login (geyser).
  • Skin success empty will now not send the locale
  • Return more clear error instead of stack trace & NullPointException
  • DefaultSkins now does not go crasy when you add name.skin as skin
  • "/sr status" is now more compact if in working state

= BUGS =

  • removed a bug that caused join error on velocity
  • Remove a unwanted debug messages when testing api status.
  • Fixed updater alignment

= Code Technical stuff =

  • A lot code moved around to reduce space
  • Added Async where missing on bungee mode
  • Earlyer Async task to reduce usage on main task.
  • Using minimalization during build to save huge ammounth of dependency space. -> reduced size
  • Updated dependency's (bstats, spigot, bungee, sponge, mysql and much more!)
  • Proper shading / relocation to remove conflicts with other plugins
  • All sponge & veclocity files now join java/net.skinsrestorer for cleaner code
  • Fixed Color mistakes & bad message alignment
  • Better platform checker
  • Reworked skincommands
    • using more Variable to have same code around platforms
    • async was only half used on some commands in sponge & velocity platforms
    • skin update now also catch api response (timed out etc)
    • skin update username check and 1x less mojangapi check to confirm premium
    • faster code improvements (operator) & startsWith instead of contains
    • Added deprecation & unused suppression so its now all "in the green".
  • Using more Lombok to automate code generation.
  • Put code on back on places it needs to be (and stay there!)
  • Adding more java documentation in part of our code.
  • forgot CoolDownReset on error at SkinUrl for sponge & velocity.
  • Using paperlib to check if it's paper without try and error.
  • Reduced nullpoint exception with human readable responce
  • Clean update error's
  • file override enablesremountentities is now disablesremountplayer
  • Fixed NoSuchMethodError on hide-/showPlayer for older versions.
  • Using more final and private where posibble
  • Using GsonfromJson instead of JsonParser
  • Added bstats to Velocity
  • Better & clearer info when the api connection is offline/blocked and what to do
  • License notice in each file

Pull requests: Thanks https://github.com/slamdunx for 395:

  • Fix for Bedrock users connecting through Floodgate.
    • Better matcher to remove all whitespace & Windows / Linux forbidden characters
  • Added DisableAutoUpdateSkin config option to disable skin updates.
    • Skin with a cooldown of 0 will now not auto update

Thanks https://github.com/1MagicSweet for 420:

  • Fixed Velocity support
    • if velocity-support is enabled, Plugin will go in bungee mode.
  • adding "enableBungeeMode" & "disableBungeeMode" file override

Thanks https://github.com/arantesxyz for 375:

  • Suggesting a better matcher for the url's
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment