Refactoring: Growing Software like a Gardener

original.py

@login_required(redirect_field_name="/")
def uploaded_pictures(request):
    pictures = AdPicture.objects.filter(user=request.user, ad__isnull=True)
    json_pics = [{'name': pic.picture.name.split("/")[-1],
                    'uuid': pic.uuid,
                    'size': pic.picture.size,
                    'thumbnailUrl': pic.picture.url} for pic in pictures]

    return JsonResponse(json_pics, safe=False)


@login_required(redirect_field_name="/")
def uploaded_pictures_of_ad(request, ad_id):
    pictures = AdPicture.objects.filter(user=request.user, ad__id=ad_id)
    json_pics = [ { 'name': pic.picture.name.split("/")[-1],
                    'uuid': pic.uuid,
                    'size': pic.picture.size,
                    'thumbnailUrl': pic.picture.url } for pic in pictures]

    return JsonResponse(json_pics, safe=False)

original_modified.txt

@login_required(redirect_field_name="/")
def uploaded_pictures_of_ad(request, ad_id=None):
    pictures = AdPicture.objects.filter(user=request.user)
    if ad_id:
      pictures.filter(ad__id=ad_id)
    else:
      pictures.filter(ad__isnull=True)
   
      
    json_pics = [ { 'name': pic.picture.name.split("/")[-1],
                    'uuid': pic.uuid,
                    'size': pic.picture.size,
                    'thumbnailUrl': pic.picture.url } for pic in pictures]

    return JsonResponse(json_pics, safe=False)